Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ForceSequence speed due to players velocity #409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrAnpu
Copy link

@MrAnpu MrAnpu commented Jul 23, 2023

Fixes animation speed. Due to players velocity, the animation would play way faster then its deafult speed.

Fixes animation speed. Due to players velocity animations would play at that given speed
Copy link

@DoopieWop DoopieWop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, i was having an issue with this a bit ago, didnt think to use this function. for consistency sake, id suggest adding spacing between the commas, to fit in with other helix code -> Vector(0, 0, 0)

@MrAnpu
Copy link
Author

MrAnpu commented Jul 23, 2023

Yeah i have been as well but thanks to a friend i've figured it out.
Also fair, i've added spacings

@@ -422,7 +422,8 @@ if (SERVER) then
-- @see LeaveSequence
function playerMeta:ForceSequence(sequence, callback, time, bNoFreeze)
hook.Run("PlayerEnterSequence", self, sequence, callback, time, bNoFreeze)

self:SetLocalVelocity(Vector(0, 0, 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can easily be replaced by vector_origin to avoid any creation of a vector object every time this function is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants