Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs keying #617

Open
wants to merge 18 commits into
base: RB-2.4
Choose a base branch
from
Open

Conversation

blackearth2014
Copy link
Contributor

Created 3 documents that include using the Hue Keyer, Multipass Keying, and Greenscreen dispilling tips.

@coveralls
Copy link

coveralls commented May 5, 2021

Coverage Status

Coverage remained the same at 0.0% when pulling e130c38 on blackearth2014:docs_keying into f9f0f50 on NatronGitHub:RB-2.4.

Keyer Node or Chromakey Node: Colorlookup node tidbit
@devernay
Copy link
Member

devernay commented May 6, 2021

Cannot review at the moment.
compiled version available at https://natron--617.org.readthedocs.build/en/617/

@blackearth2014
Copy link
Contributor Author

Cannot review at the moment.
compiled version available at https://natron--617.org.readthedocs.build/en/617/

Thanks but there is no mac version. I will check next week.

@devernay
Copy link
Member

by "compiled" I meant that the doc is available online at this address, but it seems like:

  • your additions do not have the right file extension (rst)
  • they are not referenced in the table of contents. Where would you put these?

@blackearth2014
Copy link
Contributor Author

blackearth2014 commented May 21, 2021 via email

@blackearth2014
Copy link
Contributor Author

blackearth2014 commented May 21, 2021 via email

@blackearth2014
Copy link
Contributor Author

blackearth2014 commented May 21, 2021 via email

@bonalex01dev
Copy link
Contributor

Hello, @blackearth2014, I didn't succeed to review your work either.
I suggest we integrate our additions to the docs the best we can with the existing pages.
I suggest:

  • create "tutorials-keying.rst" with a link to your pages inside.
    :maxdepth: 2
    tutorials/tutorial-multikeyer ```
    
  • edit the existing "tutorials.rst" adding a link to "tutorials-keying" in the toctree
  • edit the existing "compositing-keying.rst" with a link to your pages something like
    See :doc:`The multi keyer tutorial <tutorial-multikeyer>` section for more informations.

My understanding is that:
your pages may not be compiled if they are not integrated in the tree starting from "index.rst".
The docs says:
Sphinx requires that the toctree lists include all pages. If a page is not in any toctree list, it is a page with no parent page, or an “orphan” page, and the Sphinx build will produce an error. If for some reason a page must be in the documentation and must not be in the left navigation, the :orphan: directive can be added at the top of that page so that Sphinx will build without errors. Please avoid the :orphan: directive as much as possible. ( some of my submits may suffer the same problem I'll have to be carefull)

@bonalex01dev
Copy link
Contributor

@devernay @blackearth2014 @olear
I think it's time to get more organised for the docs. What about sharing a kanban workboard or something similar (Blender docs have one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants