Cleanup/consolidate QueryExecutorBean's Persister usage #2308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2251 (#2252)...
#2252 fixed a bug related to max results override validation by leveraging
QueryLogic.getResultLimit
in QEB's validateQuery methodThat is,
getResultLimit
takes into account all configured overrides (e.g., QueryLogic, DN, and systemFrom overrides), which is necessary to properly validate the user's ownmax.results.override
parameter.Unfortunately, that fix created even more unnecessary duplication of
Query
initialization logic in QEB....logic that I lifted fromPersister.create
, and logic that was already duplicated in several spots in QEB.So, this PR attempts to consolidate all of that into
validateQuery
, extending theQueryData
class to encapsulate the Query instance(The diff is a lot easier to read with whitespace ignored)