Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1436 global search template #1469

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

joelit
Copy link
Contributor

@joelit joelit commented May 31, 2023

Reasons for creating this PR

Twig template for global search

Link to relevant issue(s), if any

Fixes #1481 . This PR is based on #1470, and it should be reviewed first.

Description of the changes in this PR

  • global-search.twig
  • font awesome icons
  • multi-purpose search-results.inc

Known problems or uncertainties in this PR

  • The header is lacking the search bar

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe8e74a) 70.19% compared to head (ec0f4ff) 70.19%.
Report is 6 commits behind head on skosmos-3.

Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-3    #1469   +/-   ##
============================================
  Coverage        70.19%   70.19%           
  Complexity        1642     1642           
============================================
  Files               32       32           
  Lines             4314     4314           
============================================
  Hits              3028     3028           
  Misses            1286     1286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelit joelit self-assigned this Aug 31, 2023
@joelit joelit marked this pull request as ready for review August 31, 2023 06:52
@joelit joelit added this to the 3.0 milestone Aug 31, 2023
@joelit joelit added this to Needs review in Skosmos 3.0 Backlog Aug 31, 2023
@joelit joelit force-pushed the issue1436-global-search-template branch from 6f72512 to ec0f4ff Compare September 1, 2023 08:43
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joelit joelit moved this from Needs review to In progress in Skosmos 3.0 Backlog Sep 28, 2023
@MikkoAleksanteri MikkoAleksanteri moved this from In progress to Proposed Skosmos 3.0 issues (to do) in Skosmos 3.0 Backlog Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Skosmos 3.0 Backlog
  
Proposed Skosmos 3.0 issues (to do)
Development

Successfully merging this pull request may close these issues.

None yet

1 participant