Refactor sorting code for hierarchical and groups tabs #1391

kouralex · 2022-11-24T22:59:26Z

Reasons for creating this PR

Tackling issues described in #1390

Link to relevant issue(s), if any

Closes Sorting by notation does not work in groups tab if showNotation is false #1390

Description of the changes in this PR

This PR changes the code base via refactoring as some methods (namely: getLabel, pickLabel, nodeLabelSortKey, hierarchySort) and their respective code lines have been transferred from hierarchy.js to scripts.js so that they can be utilized in both hierarchy.jsand groups.js.

Additional changes were made to how $(document).on('click','div.group-hierarchy a', ... (clicking groups) was handled as there were apparent issues that stood out whilst testing the now-refactored code. A careful research and comparison with $(document).on('click', '.concept-hierarchy a', (clicking the hierarchy concepts) revealed that the code for clicking groups lacked some features the more-tested clicking hierarchy concepts had so I added them - now the jsTree hiearchy in groups tab seems to be working as expected.

Known problems or uncertainties in this PR

I noticed that autocomplete shows notation codes even after applying skosmos:showNotation "false" setting and this is how it is working in https://finto.fi/yso-aika/fi/. It may be OK for YSO-aika vocabulary, but for the vocabulary I am currently testing it certainly is not. However, fixing the aforementioned is out of the scope of this PR.

Checklist

phpUnit tests pass locally with my changes
I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)