Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency to deprecated gettext-extractor package #1257

Open
wants to merge 1 commit into
base: skosmos-2
Choose a base branch
from

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Dec 8, 2021

Reasons for creating this PR

This PR removes the dependency to twig-gettextExtractor, as it is a package no longer maintained

Link to relevant issue(s), if any

Known problems or uncertainties in this PR

This PR will not get rid of related and abandoned twig-extensions package, as it is used by the twig translation filters in Skosmos. There is a separate issue of that in #1247

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1257 (d686d6e) into master (e7f3bef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1257   +/-   ##
=========================================
  Coverage     68.85%   68.85%           
  Complexity     1627     1627           
=========================================
  Files            32       32           
  Lines          3994     3994           
=========================================
  Hits           2750     2750           
  Misses         1244     1244           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f3bef...d686d6e. Read the comment docs.

Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No code updated, so I assume it was not in use. CI green so shouldn't break anything I guess.

@osma
Copy link
Member

osma commented Feb 11, 2022

There is also a static, modified copy of twig-gettext-extractor under tools/twig-gettext-extractor. If we want to excise it completely, that should probably be removed too (which would also remove the tools directory as it's the only file there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed items for this sprint
Development

Successfully merging this pull request may close these issues.

Updating twig-gettext extractor (and possibly changes for translating Finnish, Swedish and English UI)
3 participants