test(encryption): add integration test for db encryption #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
changed the title
TBonnin
approved these changes
May 13, 2024
| } | ||
|
|
||
| await this.encryptDatabase(); | ||
| await this.saveDbConfig({ encryption_key_hash: encryptionKeyHash, encryption_complete: true }); |
There was a problem hiding this comment.
unrelated to your changes but all the queries in encryptDatabase and saveDbConfig should probably be inside a transaction.
There was a problem hiding this comment.
At first glance yes, I'm just wondering about the size of the transaction if you have a large db. I think the script assume it can fail at any time and try everything from the start every time which is nice imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
encryptDatabaseIfNeededOnly check environment because that what I was trying to fix
How to test?
NANGO_ENCRYPTION_KEYfrom your .env should throwError: A previously set NANGO_ENCRYPTION_KEY has been removed from your environment variables.NANGO_ENCRYPTION_KEYshould throwRotation of NANGO_ENCRYPTION_KEY is not supported.