feat(orchestration): introducing the scheduler #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
force-pushed
the
tbonnin/orchestration-v2.0
branch
7 times, most recently
from
59b50d5
to
ff4b239
Compare
TBonnin
changed the title
bodinsamuel
reviewed
May 13, 2024
packages/scheduler/lib/db/migrations/20240506105059_initial_scheduler_models.ts
Outdated
Show resolved
Hide resolved
packages/scheduler/lib/db/migrations/20240506105059_initial_scheduler_models.ts
Outdated
Show resolved
Hide resolved
bodinsamuel
reviewed
May 13, 2024
TBonnin
force-pushed
the
tbonnin/orchestration-v2.0
branch
from
ff4b239
to
ad1e099
Compare
|
I addressed all your comments @bodinsamuel |
TBonnin
force-pushed
the
tbonnin/orchestration-v2.0
branch
from
ad1e099
to
1fe2f9d
Compare
khaliqgant
reviewed
May 13, 2024
| }) | ||
| .forUpdate() | ||
| .skipLocked() | ||
| .debug(true) |
There was a problem hiding this comment.
Intentional I presume to leave this in while under development @TBonnin ?
There was a problem hiding this comment.
no actually it is some dev leftover. I will remove it
|
Looks good! Tests 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage of the orchestration v2, implementing the scheduler.
As agreed the first version of the scheduler doesn't support recurring tasks, only tasks that are scheduled immediately.
schedulerpackage is not used yet but it is big enough to warrant a review. There is still a few TODOs, which I will address in subsequent PRsIssue ticket number and link
https://linear.app/nango/document/[brief]-orchestration-v2-4c5d1f1e104b#94b7a156-de22-4ce2-8a77-9cfcfe1fcece
Checklist before requesting a review (skip if just adding/editing APIs & templates)