feat(db): add ability to change schema name #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this only apply to the main db or should we do the same for |
|
Good question, I did it while debugging the main db but could be interesting to have it for all db. Let me change that |
|
Can I have a review on this please? |
TBonnin
approved these changes
May 13, 2024
## Describe your changes - Test `encryptDatabaseIfNeeded` Only check environment because that what I was trying to fix ## How to test? - Removing `NANGO_ENCRYPTION_KEY` from your .env should throw `Error: A previously set NANGO_ENCRYPTION_KEY has been removed from your environment variables.` - Changing `NANGO_ENCRYPTION_KEY` should throw `Rotation of NANGO_ENCRYPTION_KEY is not supported.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Contributes NAN-900
For testing purpose, local dev, and also to be able to have multiple install in the same DB. @khaliqgant I believe it could also match your local setup.
I need this to be able to run some specific integration tests