Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error unable to get local issuer certificate #2003

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TBonnin
Copy link
Collaborator

@TBonnin TBonnin commented Apr 17, 2024

RDS certificate is self-sign and therefore rejected when trying to connect with sslmode=required
This change prevents the cert verification to fail the ssl connection

RDS certificate is self-sign and therefore rejected when trying to
connect with sslmode=required
This change prevents the cert verification to fail the ssl connection
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way around RDS being self signed?

@TBonnin
Copy link
Collaborator Author

TBonnin commented Apr 17, 2024

No way around RDS being self signed?

couldn't find anything. The only cert authority options are rds-ca-...

Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright for us, but might not be ideal for self-hosted / enterprise customer since it's a "secruity downgrade". Can it be parametrized?
Yes the only other way would be to load the certif in the docker image but painful

@bodinsamuel
Copy link
Contributor

should this be closed?

@TBonnin
Copy link
Collaborator Author

TBonnin commented May 7, 2024

It needs to be addressed but it is not at the top of my list. I am basically keeping it to remind me to take care of it at some point. I am happy to close and reopen if you prefer

@bodinsamuel
Copy link
Contributor

bodinsamuel commented May 7, 2024

no worries, I was just browsing the open PRs. Maybe you can put it in draft for now

@TBonnin TBonnin marked this pull request as draft May 7, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants