New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug where user can't select some resolutions in game #55
base: main
Are you sure you want to change the base?
Conversation
…re_materials dependency version from 12 to 11 to be build compliant
fyi (nv) - this is already integrated into dxvk: doitsujin/dxvk#3214 |
There was an issue with version 12 of @sortifal Please test with version 12 of |
The v12 of 'rtx-remix-omni_core_materials' now compile properly but the resolutions problem is still here. Do you want me to make a new PR with v12 ? |
@sortifal No, you can keep this PR in place, just modify the configs to pull v12 of Thank you for confirming and verifying that the resolution issue is still present, even with v12. |
I know pushed a fix with v12 of |
@sortifal thank you for putting this PR together. I noticed that this fix is a squashed version of the upstream fix from DXVK (commits below). Would it be possible to cherrypick those commits directly? This will greatly help us when it comes time to merge upstream DXVK into Remix. Also please add yourself as a contributer to the credits (see doitsujin/dxvk@1568c26 |
Hello, I tried to compile by cherry-picking thoses 3 commits but he moved all operators out of dxvk namespace that conclude to a build error for previous definitions of thoses operators. Then only the |
REMIX-3065 for tracking |
I know it's been a while but I added myself as contributor as you said so |
Fixed a bug where resolutions could'nt be set properly on high resolutions. Set back omni material dependecy version back to 11 to be build compliant.