Gg/cmake from local files #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 23, 2020 20:55
use package and set unpack_download to False.
gonzalobg
reviewed
Nov 6, 2020
There was a problem hiding this comment.
Thank you for the PR, this looks good to me.
The generic_build building-block recently got a similar option (https://github.com/NVIDIA/hpc-container-maker/blob/master/hpccm/building_blocks/generic_build.py#L111) that I just called "unpack" there.
I think we should give this option the same name on all blocks for consistency.
Personally, I like the unpack_download name that this PR uses more, since it clarifies what the option does.
| @@ -136,6 +136,9 @@ class generic_cmake(bb_base, hpccm.templates.CMakeBuild, | |||
| url: The URL of the package to build. One of this parameter or | |||
| the `repository` or `package` parameters must be specified. | |||
|
|
|||
| unpack_download: if the URL or package specified needs to be unpacked. | |||
| The default is True | |||
There was a problem hiding this comment.
Suggested change
| The default is True | |
| The default is True. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Hey Scott, in one of our workflows, a warning from the download_step (and in downloader.__unpack()) within generic_cmake.__setup() was getting slurped into the dockerfile.
I'm working with Adam to not pull in STDERR into the dockerfile as its not necessary but I thought this update might still be valuable for users who are copying a directory into their image like myself.
The update is simply exposing the download_step's unpack kwarg as an option to generic_cmake "unpack_download".
If there is already a supported way to do this, I'm happy to hear about it.
Author Checklist
pydocmd generate) if any docstrings have been modified