Support use of external/system GTest installation #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-k-b
approved these changes
Apr 11, 2024
|
This PR has been labeled |
|
Is there an additional step needed for merging? Anything I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Re-push of #1384)
I am building the project in a restricted environment that does not allow network access (so FetchContent is not usable), and already have a pre-compiled build of GTest ready to go. With this change, I can pass
-DCUTLASS_USE_SYSTEM_GOOGLETEST=ON -DGTest_ROOT=/path/to/gtest-installto CMake, and the tests will build using the specified install. A system install of GTest can also be picked up.The second commit fixes a related issue: the test suite breaks when the
bin/subdirectory is missing from the build tree, but it's the bundled-googletest logic that creates it. So we create that dir explicitly/unconditionally.