Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up complex.inl #1655

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ZelboK
Copy link
Contributor

@ZelboK ZelboK commented Apr 21, 2024

while trying to understand thrusts complex i noticed a bunch of useless outdated macros that can be removed

@ZelboK ZelboK requested review from a team as code owners April 21, 2024 16:31
Copy link

copy-pr-bot bot commented Apr 21, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco
Copy link
Collaborator

miscco commented Apr 22, 2024

pre-commit.ci autofix

@miscco
Copy link
Collaborator

miscco commented Apr 22, 2024

I would advice to not spend too much time with thrust::complex The only reason it is still there are numerical issues in our cuda::std::complex implementation. It will be gone soon ^TM

@miscco
Copy link
Collaborator

miscco commented Apr 22, 2024

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants