Add nvhpc devcontainer to CI #1488
Open
+81
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
jrhemstad
reviewed
Mar 5, 2024
jrhemstad
reviewed
Mar 5, 2024
| @@ -84,6 +87,7 @@ pull_request: | |||
| - {cuda: *cuda_curr, os: 'windows2022', cpu: 'amd64', compiler: *msvc2019, std: [14, 17], jobs: ['build']} | |||
| - {cuda: *cuda_curr, os: 'windows2022', cpu: 'amd64', compiler: *msvc2022, std: [14, 17, 20], jobs: ['build']} | |||
| - {cuda: *cuda_curr, os: 'ubuntu22.04', cpu: 'amd64', compiler: *oneapi, std: [11, 14, 17], jobs: ['build']} | |||
| - {cuda: *cuda_curr, os: 'ubuntu22.04', cpu: 'amd64', compiler: *nvhpc, std: [11, 14, 17, 20], jobs: ['build']} | |||
There was a problem hiding this comment.
note for the future: This is a little wonky because it would lead someone to believe that they could control the CUDA version separate from the nvhpc version. The current matrix logic isn't built to expect that a host compiler would come with its own CTK. Not sure how to cleanly handle that, but that'll be a problem for future self :)
There was a problem hiding this comment.
It is but I would rather not completely rewrite the whole matrix for that one use case
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
jrhemstad
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also support the latest nvc++ as a host compiler, so we should test it in CI