Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overload to set_difference_by_key #1385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eriktedhamre
Copy link
Contributor

@eriktedhamre eriktedhamre commented Feb 14, 2024

Description

Hello!
Unsure if this is a correct interpretation and solution to the issue below.
I would appreciate feedback!

closes [https://github.com//issues/785]

Added overload for set_difference_by_key(....) that uses thrust::constant_iterator for values_first2.
I'm not sure if this should be extended to also exist for other version, for example the one with a custom comparator.

Checklist

I tried to add a simple test case to test my change, not user if this is the correct way to go about it. The documentation for how tests should be written for thrust is not as extensive as the one for CUB.
In regards to documentation, I have not changed anything. Because I'm unsure about what to do.

Copy link

copy-pr-bot bot commented Feb 14, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@eriktedhamre
Copy link
Contributor Author

That merge should probably have been a rebase.

@jrhemstad
Copy link
Collaborator

Thanks @eriktedhamre, we'll take a look at this right away!

That merge should probably have been a rebase.

No worries, we're not picky about merge commits in PRs because we just squash merge them 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants