Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-17 to ci #1361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add clang-17 to ci #1361

wants to merge 1 commit into from

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Feb 9, 2024

Fixes #1360

@miscco miscco requested review from a team as code owners February 9, 2024 13:07
@miscco miscco added feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure labels Feb 9, 2024
@miscco miscco requested a review from elstehle February 9, 2024 13:07
@jgehrcke
Copy link

jgehrcke commented Feb 9, 2024

Much appreciated! ❤️

jrhemstad
jrhemstad reviewed Feb 9, 2024
View reviewed changes
ci/matrix.yaml
@@ -30,8 +30,9 @@ llvm13: &llvm13 { name: 'llvm', version: '13', exe: 'clang++' }
llvm14: &llvm14 { name: 'llvm', version: '14', exe: 'clang++' }
llvm15: &llvm15 { name: 'llvm', version: '15', exe: 'clang++' }
llvm16: &llvm16 { name: 'llvm', version: '16', exe: 'clang++' }
llvm16: &llvm17 { name: 'llvm', version: '17', exe: 'clang++' }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
llvm16: &llvm17 { name: 'llvm', version: '17', exe: 'clang++' }
llvm17: &llvm17 { name: 'llvm', version: '17', exe: 'clang++' }

@jrhemstad
Copy link
Collaborator

jrhemstad commented Feb 9, 2024 •
edited

Also, this won't work because clang17 isn't a supported host compiler for CUDA 12.3.

The clang-cuda CI jobs should be fine with clang17 though.

@miscco miscco added the blocked This PR cannot be merged due to various reasons label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@jarmak-nv jarmak-nv Awaiting requested review from jarmak-nv jarmak-nv is a code owner automatically assigned from NVIDIA/cccl-infra-codeowners

@griwes griwes Awaiting requested review from griwes griwes is a code owner automatically assigned from NVIDIA/cccl-codeowners

@elstehle elstehle Awaiting requested review from elstehle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked This PR cannot be merged due to various reasons feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: llvm / clang 17 CI coverage
3 participants
@miscco @jgehrcke @jrhemstad