Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gcc13 to testing matrix. #1167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add gcc13 to testing matrix. #1167

wants to merge 6 commits into from

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Nov 30, 2023

Description

Adds gcc13 to our testing matrix.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wmaxey wmaxey requested review from a team as code owners November 30, 2023 19:53
@gevtushenko
Copy link
Collaborator

Might be blocked by #1174

jrhemstad
jrhemstad reviewed Jan 16, 2024
View reviewed changes
ci/matrix.yaml Outdated Show resolved Hide resolved
miscco and others added 2 commits January 17, 2024 16:27
@miscco @jrhemstad
Update ci/matrix.yaml
bd376aa 
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
@miscco
Update devcontainer default
cf7e4e8
@jrhemstad
Copy link
Collaborator

The gcc13 jobs will continue to fail because CUDA 12.3 doesn't officially support gcc13 yet: https://github.com/NVIDIA/cccl/actions/runs/7559215520/job/20582713337?pr=1167#step:8:233

We'd need to add -allow-unsupported-compiler to the build flags and decide if that's something we want to just add to the default build flags, or only add it only for the relevant config (gcc13 in this case).

@miscco miscco added infrastructure Shared CMake, github, etc infrastructure blocked This PR cannot be merged due to various reasons labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@jarmak-nv jarmak-nv Awaiting requested review from jarmak-nv jarmak-nv is a code owner automatically assigned from NVIDIA/cccl-infra-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked This PR cannot be merged due to various reasons infrastructure Shared CMake, github, etc infrastructure
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wmaxey @gevtushenko @jrhemstad @miscco