Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: llvm / clang 17 CI coverage #1360

Open
1 task done
jgehrcke opened this issue Feb 9, 2024 · 3 comments · May be fixed by #1361
Open
1 task done

[FEA]: llvm / clang 17 CI coverage #1360

jgehrcke opened this issue Feb 9, 2024 · 3 comments · May be fixed by #1361
Labels
feature request New feature or request.

Comments

@jgehrcke
Copy link

jgehrcke commented Feb 9, 2024

Is this a duplicate?

Area

libcu++

Is your feature request related to a problem? Please describe.

Hello! We see that in CI you are covering the binaries from the LLVM 16.x releases, but there is no coverage yet for the 17.x releases:

llvm-newest: &llvm-newest { name: 'llvm', version: '16', exe: 'clang++' }

That's something that is very interesting for us.

Anecdote: we are debugging a clang-tidy error which is actually a compilation error: clang is tripped up by code in libcudacxx/cuda/std/detail/libcxx/include and for our debugging it was interesting to see where you are in terms of supporting clang 17.

Describe the solution you'd like

cover clang 17 in your CI

Describe alternatives you've considered

n/a

Additional context

No response

@jgehrcke jgehrcke added the feature request New feature or request. label Feb 9, 2024
@miscco
Copy link
Collaborator

miscco commented Feb 9, 2024

Did they perchance add another builtin that is named like a function?

miscco added a commit to miscco/cccl that referenced this issue Feb 9, 2024
@miscco miscco linked a pull request Feb 9, 2024 that will close this issue
@miscco
Copy link
Collaborator

miscco commented Feb 9, 2024

I have opened a PR to add clang-17 to our CI matrix.

@jgehrcke
Copy link
Author

jgehrcke commented Feb 9, 2024

I have opened a PR to add clang-17 to our CI matrix.

Thank you! That is a super fast turnaround. I trust that this will be useful, but I am also slightly sorry because in the meantime we have understood the root cause of our troubles. I have summarized that here:
rapidsai/rmm#1307 (comment)

You have nicely patched the problem we were seeing a long while ago (for clang 16 support), but rapids memory manager 23.12 vendors an old version of libcudacxx! :) sorry for the noise 🔊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants