-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPEG-4 Part2 decoding support #4361
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
class FramesDecoderGpuMpeg4Test : public FramesDecoderGpuTest { | ||
void AssertFrame(uint8_t *frame, int index, TestVideo& ground_truth) override { | ||
MemCopy(FrameDataCpu(), frame, ground_truth.FrameSize()); | ||
SaveFrame(FrameDataCpu(), index, 0, 0, "/home/awolant/Downloads/frames/", ground_truth.Width(), ground_truth.Height()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CI MESSAGE: [6216597]: BUILD STARTED |
CI MESSAGE: [6216597]: BUILD FAILED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
CI MESSAGE: [6225403]: BUILD STARTED |
CI MESSAGE: [6225403]: BUILD FAILED |
CI MESSAGE: [6226244]: BUILD STARTED |
CI MESSAGE: [6226244]: BUILD FAILED |
I think you need to update conda/third_party/dali_ffmpeg/recipe/build.sh and https://github.com/NVIDIA/DALI/blame/main/docs/compilation.rst#L205 |
Adds MPEG-4 Part2 decoding support for
FramesDecoder
andFramesDecoderGpu
for all usage patterns (regular, in-memory, no index).Category:
Description:
Based on #4327 by @JanuszL
Requires NVIDIA/DALI_deps#61 deps PR and NVIDIA/DALI_extra#109 DALI_extra PR.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A