Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@GW_USE_DEVICE_ALLOCATOR_FILE@ #634

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

pb-cdunn
Copy link

Set @GW_USE_DEVICE_ALLOCATOR_FILE@ based on gw_enable_caching_allocator, to include only one DefaultDeviceAllocator for a given installation.

This way, after the library is built and installed, the user does not need to specify -DGW_ENABLE_CACHING_ALLOCATOR,
which would currently select the DefaultDeviceAllocator to use.

I have not tested this yet. (I think we will need to add the build-directory to the include path.) I wanted to get opinions on this idea first.

To be clear, here is the error that can hit if we fail to use the same compilation flags as when the library was installed:

src/libpancake.so.1.1.0: undefined reference to
`claraparabricks::genomeworks::cudaaligner::create_aligner(
    claraparabricks::genomeworks::cudaaligner::AlignmentType, int, CUstream_st*, int,
    claraparabricks::genomeworks::CudaMallocAllocator<char>, long)'

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@ahehn-nv
Copy link
Contributor

HI @pb-cdunn , thanks for submitting this PR. This certainly is a problem that needs to be addressed. We are evaluating your PR and will get back to you soon.

@ahehn-nv ahehn-nv self-assigned this Feb 25, 2021
@ahehn-nv ahehn-nv added bug Something isn't working sdk Overall SDK related improvements and removed bug Something isn't working labels Feb 25, 2021
@ohadmo
Copy link
Member

ohadmo commented Feb 25, 2021

ok to test

based on gw_enable_caching_allocator

This way, after the library is built and installed, the user
does not need to specify `-DGW_ENABLE_CACHING_ALLOCATOR`,
which would select the DefaultDeviceAllocator to use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Overall SDK related improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants