forked from sigmf/sigmf-python
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi recording archive #1
Draft
jhazentia
wants to merge
29
commits into
main
Choose a base branch
from
multi-recording-archive
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
208d74b
add support for multiple recordings in archives
jhazentia 44462f1
fix SigMFArchiveReader error
jhazentia 832b731
support single or multiple sigmffiles in archive __init__()
jhazentia 8d25adf
renamed archive "name" to "path", allow os.PathLike
jhazentia 4f58453
Fixed bug in checking sigmffiles type
jhazentia 89242c8
add test for missing name
jhazentia 0c503ab
require name in SigMFFile constructor
jhazentia d234ddf
return single or list of SigMFFiles in fromarchive
jhazentia 348bed8
fix some formatting, unused imports, docstrings, rename archivereader…
jhazentia b6df262
add support for collections in archives, check for path and fileobj i…
jhazentia 4cfc8c2
rename collectionfile to collection
jhazentia ea4e633
make json end of file new line consistent, add support for collection…
jhazentia 68c6825
add README examples for archives with multiple recordings
jhazentia 454dd34
fix archive docstring, remove unneeded variables from archivereader
jhazentia af9002d
simplify SigMFCollection archive tests
jhazentia f1d108b
organize SigMFFile constructor doc string
jhazentia a631eb3
clarify different ways to do the same thing in README
jhazentia 74a7b86
fix typo
jhazentia ae4c424
Merge branch 'main' of https://github.com/NTIA/sigmf-python into mult…
jhazentia 93ab02b
add support for passing SigMFFile objects to SigMFCollection to impro…
jhazentia 5376ece
fix SigMFCollection docstring
jhazentia 46e7d8f
SigMFCollection set_streams() will check type for each element of met…
jhazentia 660ba82
break up and simplify archive examples in README
jhazentia e2919d8
fix docstring, add ability to control pretty print JSON for archive
jhazentia e4e1775
update docstrings, formatting
jhazentia 3131683
improve docstrings, remove duplicative test, add test for fromarchive…
jhazentia 29827af
fix error message
jhazentia b81289b
make archives work when using folders
jhazentia 15ca451
folders in archives are no longer created by default to maintain cons…
jhazentia File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventual PR should call out this change in behavior and note that it could be changed to preserver the original behavior of writing over the archive.