Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DLL and driver versions unset when running ITMDRvr.exe -v #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aromanielloNTIA
Copy link
Member

Resolves #17

This issue was caused because the call to the Version() function specified by the -v flag occurs before the DLL is loaded. This change loads the DLL up front, so that version information is populated before the call to Version().

I also changed the name of drvrVerDrvr to drvrVerPatch, to be consistent with semantic versioning major/minor/patch version numbers. I also added the drvrVerPatch to be printed in the -v message (it was already printed to the output file)

Example output:

*******************************************************
Institute for Telecommunications Sciences - Boulder, CO
        ITM Driver Version: 1.4.0
        ITM DLL Version: 1.4
        Time: Wed May  8 17:24:33 2024
*******************************************************

This allows DLL and driver version variables to populate before a potential call to the Version() function. This fixes the issue where the DLL and driver version variables were unset when running `ITMDrvr.exe -v`
@aromanielloNTIA aromanielloNTIA self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITMDrvr does not correctly print DLL or driver versions
1 participant