New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import json as SAM case #969
Conversation
Single Owner running - other compute modules are not
SAM and ssc both use dispatch_tod_factors array type
It looks like the change to adjustment factors correctly imports inputs from the SAM UI as-is, so we won't need to use the version upgrade script to handle opening files from older versions of SAM. @sjanzou, is that correct? Not sure what impact this will have on the need for the "AdjustmentFactors" group in PySAM, for example in the Pvwattsv8 documentation: https://nrel-pysam.readthedocs.io/en/master/modules/Pvwattsv8.html#adjustmentfactors-group. We may need to add instructions for converting to the new table format in the PySAM documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems to work, and this is a great improvement, but there needs to be a lot of clean-up around commented out code, the test runner, and documentation of the new SSC_TABLE variables.
...2022.08.08_develop_branch_Geothermal_Power_All_Equity_Partnership_Flip_cmod_equpartflip.json
Show resolved
Hide resolved
Comments removed and tests being updated |
Everything is flattened now, so the SSC_TABLE variables from SAM are non-existent. |
implicit definition of function is invalid in C99 an later treated as error now. Add function prototype at top of file to build.
Fixes ETES, PTES equation issue when loading case adjust_hourly functionality kept for scripting but was removed from UI in previous release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSC_TABLE removed from inputs from SAM and all requested changes made
All requested changes have been made and SSC_TABLE are not used for inputs from SAM
Updates to MSPT compute module to enable importing jsons (e.g. generated via Shift + F5) as a SAM case:
This pull request also includes modifications relevant for non-MSPT technologies:
@sjanzou Please add anything I'm missing