Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to address SAM issue 1477 for host developer only #1141

Open
wants to merge 3 commits into
base: patch
Choose a base branch
from

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Feb 29, 2024

I think we should review in detail before proceeding with host developer and other markets.

See NREL/SAM#1722

@sjanzou
Copy link
Collaborator Author

sjanzou commented Feb 29, 2024

Test file
ITC_basis_reduction.zip

Test with no IBI
image

Test with IBI with no basis reduction
image

Test with IBI with federal and state basis reduction
image

Test with federal and state taxable IBI and federal and state basis reduction
image

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment NREL/SAM#1477

@brtietz
Copy link
Collaborator

brtietz commented Feb 29, 2024

The ITC amounts now have the behavior that I'd expect, but I'm a little concerned that IBI isn't showing up in purchase of property:

image

Would some of the test processes from #1047 be relevant here?

@sjanzou
Copy link
Collaborator Author

sjanzou commented Mar 1, 2024

The ITC amounts now have the behavior that I'd expect, but I'm a little concerned that IBI isn't showing up in purchase of property:

image

Would some of the test processes from #1047 be relevant here?

I think much more testing is in order here and for all of the financial markets.

I am leaning towards moving issue NREL/SAM#1477 and NREL/SAM#1722 to patch 2 - any objections?

@brtietz
Copy link
Collaborator

brtietz commented Mar 1, 2024

@sjanzou Agreed. The milestones for those issues have been changed to patch 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ITC and incentives interactions for host developer market only per test file
3 participants