Kyle move selected spaces #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 23, 2021 11:29
kylem038
commented
Aug 25, 2021
| @@ -79,7 +79,6 @@ export default function createFaceFromPoints(context, payload) { | |||
| // split edges where vertices touch them | |||
There was a problem hiding this comment.
No changes here. Just some clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completed #376
We've added an icon to each space which will make a modal appear asking the user to adjust the space's upper-left X/Y to a new position. Hitting the Save button moves that space.
Generally happy with the implementation although I think I need to determine the upper-left corner more directly? Maybe I can follow how
registerSelectEventsworks?Edit: I'm not sure
registerSelectEventsdirectly translates. That uses the drag event to set an origin which everything works off of. Could use some help figuring out the best way to pick an origin for this dialog.