Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to provide their own buildstock.csv file #46

Merged
merged 8 commits into from May 15, 2019
Merged

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented May 7, 2019

Fixes #30

@aspeake1 I haven't done any testing on Eagle for this one (system time). Can you test it out and see if it works?

The way to use it is to add a buildstock_csv key to the baseline group.

baseline:
    buildstock_csv: /path/to/your/buildstock.csv
    # comment this line out because it can't use both and will error out if you try.
    # n_datapoints: 350000 
    n_buildings_represented: 80000000

Can you also update the documentation to reflect this change? It's in the docs/ folder. See the restructured text primer on the markup format. PyCharm is generally good at autogenerating the preview of it. Otherwise the rendered docs will show up in the artifacts of the CircleCI build. Let me know if you have questions.

@nmerket nmerket requested a review from aspeake May 7, 2019 22:02
@nmerket
Copy link
Member Author

nmerket commented May 9, 2019

I tested this on both Eagle and locally using docker. Seems to work as expected.

@aspeake1 Go ahead and use this branch for your analysis and when you're satisfied that's it is working, approve it and I'll get it merged. No hurry.

@nmerket nmerket merged commit aef2922 into master May 15, 2019
@nmerket nmerket deleted the nosampling branch May 15, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to specify their own buildstock.csv
2 participants