ResStock-HPXML #169
ResStock-HPXML #169
Conversation
There was a problem hiding this comment.
@joseph-robertson The main thing I did was rename references to building_unit_id back to building_id. Can you look over that and verify I didn't mess it up too much? Also I merged in the develop branch and tried to fix any merge conflicts.
These notes below are mostly for me, but if you have any insights, please chime in.
buildstockbatch/base.py
Outdated
| timeseries_filepath = os.path.join(sim_dir, 'run', 'enduse_timeseries.csv') | ||
| timeseries_filepath = os.path.join(sim_dir, 'run', 'results_timeseries.csv') |
There was a problem hiding this comment.
I think ComStock is still writing out enduse_timeseries.csv so we may need to either get them to do the same or have a conditional look for the new filename here.
buildstockbatch/base.py
Outdated
| tsdf = pd.read_csv(timeseries_filepath, parse_dates=[0]) | ||
| tsdf = pd.read_csv(timeseries_filepath, parse_dates=['Time'], skiprows=[1]) |
There was a problem hiding this comment.
Maybe want to make this parse_dates=[0] again. I think someone changed it from "Time" to "time" and that broke everything. Using 0 makes it just parse the first column.
buildstockbatch/base.py
Outdated
| for measure_dir in measure_names.keys(): | ||
| for measure_name in measure_names[measure_dir].keys(): | ||
| measure_path = os.path.join(measure_dir, measure_name) | ||
|
|
||
| if measure_names[measure_dir][measure_name] in cfg.keys() or \ | ||
| measure_names[measure_dir][measure_name] == 'residential_simulation_controls': |
There was a problem hiding this comment.
This is a lot. As part of the refactor I want to do I'd like to do this validation as part of the workflow generator class.
Pull Request Description
This is the companion PR to: NREL/resstock#443
OS-BuildStock (branch: restructure-v3) requires OpenStudio 3.0.0. Therefore, buildstockbatch will need to move to OpenStudio 3.0.0. [Update: now requires OpenStudio 3.1.0.]
Checklist
Not all may apply