pass a copy of sceneDict to _makeSceneNxR. fixes #502. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shirubana - I think this quick bug fix is ready to go. Tests are passing aside for the minor delta in coveralls coverage. |
|
@cdeline I see you removed removed hub_height from the dictionary. Is it still being saved somewhere? Other htan that I'm okay to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of copying some of the keys of sceneDict into a sceneDict2 and passing that to _makeSceneNxR, this updates the appropriate keys, and makes sure that _makeSceneNxR is working from a copy.deepcopy of sceneDict. Because it's a mutable type, this dict was being updated within the makeScene1axis loop. Using a copy here solves that problem.