Refactor NSRDBWeatherData #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did this got finished to merge ? |
|
Yes, this is functional and has pytests. We might want to consider demonstrating the functionality in a notebook or two, with the new function name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the dev branch, refactor
NSRDBWeatherDatafunction to be a more generalreadWeatherData. This splits the existingreadWeatherFilefunction into two parts - the first half for reading different weather files (TMY3, SAM, EPW, solarGIS) and putting it into a consistent format metadata dictionary and metdata DataFrame. Then the newreadWeatherDatafunction takes those inputs and does the parsing work. Now, NSRDB data can just be injected into the readWeatherData function without requiring any special function.