add FlexibleHVAC to MPC module #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to read JSON file to extract inputs for FlexHVAC struct when doe reference profile is provided
s.t. we can reuse the city in FlexibleHVAC; should probably do the same in the thermal loads from DoE CRBs
sometimes getting 0.99999, which fails in Bool(binFlexHVAC)
original FlexibleHVAC model had input_node = control_node; that is no longer the case for the DoE CRB RC models
- was using x[t+1] = x[t] + A x[t] + B u[t] but the DoE RC models were fit to the form x[t+1] = A x[t] + B u[t] - also removed the `input_vec` - model form also required changing the FlexHVAC test: convert continuous SS model to discrete instead of doing an Euler approximation of the continuous model
b/c it has MAE > 1 deg C
when not modeling FlexibleHVAC
some outputs were moved to "Outages" awhile back
not modeling FlexibleHVAC in problem yet
require users provide their RC model, don't use DoE RC models because it is wired for 8760 models
rathod-b
reviewed
Jun 28, 2022
| See the [ElectricLoad](@ref) docs for `city` options. | ||
|
|
||
|
|
||
| !!! note |
There was a problem hiding this comment.
Should these docs be updated to reflect _cooling or _heating suffixes to say either temperature_upper_bound_degC_cooling or temperature_lower_bound_degC_heating are required inputs?
rathod-b
reviewed
Jun 28, 2022
| get(d["FlexibleHVAC"], "temperature_upper_bound_degC_cooling", nothing), | ||
| get(d["FlexibleHVAC"], "temperature_lower_bound_degC_cooling", nothing), | ||
| ) | ||
| elseif flex_hvac_from_json # then have to convert vector of vectors to matrix |
There was a problem hiding this comment.
From what I can tell, flex_hvac_from_json boolean has to be provided programmatically to Scenario function. Should we move this boolean as an input key under Settings or under FlexHVAC struct so future API users can interact with this functionality via JSON posts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch includes changes in
rcmodelsand so should be merged after #30