Added ASHP (for space heating & cooling) #372

atpham88 · 2024-04-08T16:05:21Z

Notes

This PR adds space heating ASHP to REopt
Electric Heater's heating_cop is replaced with backup_heating_cop

zolanaj · 2024-04-29T21:45:27Z

@Bill-Becker tagging you for a second set of eyes on this PR; once testing improvements have been merged, so will add-process-heat-load, and then the target ranch will be moved to develop. I can then work on the version update.

zolanaj

Thank you for getting this together @atpham88! My edits were focused on allowing the ASHP system to cool as well, and then some additional things beyond that to get all tests passing. I'm passing to @Bill-Becker for a second set of eyes now.

zolanaj · 2024-04-29T21:57:47Z

src/core/reopt_inputs.jl

+    heating_cop::Dict{String, Array{<:Real, 1}} # (techs.ashp)
+    cooling_cop::Dict{String, Array{<:Real, 1}} # (techs.ashp)


Just a note that the heating_cop and cooling_cop are modeled inputs that are a time series. They are separated because ASHP is both a heating and cooling tech and, unlike GHP, does not have preprocessed production.

zolanaj · 2024-04-29T22:01:00Z

test/test_with_xpress.jl

+@testset "ASHP" begin
+    d = JSON.parsefile("./scenarios/ashp.json")
+    d["SpaceHeatingLoad"]["annual_mmbtu"] = 0.5 * 8760
+    d["DomesticHotWaterLoad"]["annual_mmbtu"] = 0.5 * 8760
+    s = Scenario(d)
+    p = REoptInputs(s)
+    m = Model(optimizer_with_attributes(Xpress.Optimizer, "OUTPUTLOG" => 0))
+    results = run_reopt(m, p)
+
+    #first run: Boiler produces the required heat instead of ASHP - ASHP is not purchased here
+    @test results["ASHP"]["size_mmbtu_per_hour"] ≈ 0.0 atol=0.1
+    @test results["ASHP"]["annual_thermal_production_mmbtu"] ≈ 0.0 atol=0.1
+    @test results["ASHP"]["annual_electric_consumption_kwh"] ≈ 0.0 atol=0.1
+    @test results["ElectricUtility"]["annual_energy_supplied_kwh"] ≈ 87600.0 atol=0.1
+
+    d["ExistingBoiler"]["fuel_cost_per_mmbtu"] = 100
+    d["ASHP"]["installed_cost_per_mmbtu_per_hour"] = 1.0
+    d["ElectricTariff"]["monthly_energy_rates"] = [0,0,0,0,0,0,0,0,0,0,0,0]
+    s = Scenario(d)
+    p = REoptInputs(s)
+    m = Model(optimizer_with_attributes(Xpress.Optimizer, "OUTPUTLOG" => 0))
+    results = run_reopt(m, p)
+
+    annual_thermal_prod = 0.8 * 8760  #80% efficient boiler --> 0.8 MMBTU of heat load per hour
+    annual_ashp_consumption = annual_thermal_prod * REopt.KWH_PER_MMBTU  #1.0 COP
+    annual_energy_supplied = 87600 + annual_ashp_consumption
+
+    #Second run: ASHP produces the required heat with free electricity
+    @test results["ASHP"]["size_mmbtu_per_hour"] ≈ 0.8 atol=0.1
+    @test results["ASHP"]["annual_thermal_production_mmbtu"] ≈ annual_thermal_prod rtol=1e-4
+    @test results["ASHP"]["annual_electric_consumption_kwh"] ≈ annual_ashp_consumption rtol=1e-4
+    @test results["ElectricUtility"]["annual_energy_supplied_kwh"] ≈ annual_energy_supplied rtol=1e-4
+
+end
+


Just confirming - we're going to excise this test file, right? (I can do that in a separate PR, removing the test_with_xpress.jl file and the testset header for imported xpress tests. I didn't want to do that for the testing speed improvements PR because I wanted the test adjustments to be clear to the reviewer.)

Yes, we should be doing all tests in HiGHS, and we don't need to add to test_with_xpress.jl.

…ASHP

…nto add-ASHP" This reverts commit 3391569, reversing changes made to 3c23e46.

Bill-Becker

Thanks Alex and An, looks good! I have one units change request and a few other comments.

Bill-Becker · 2024-05-09T23:39:05Z

src/core/ashp.jl

+"""
+function ASHP(;
+        min_mmbtu_per_hour::Real = 0.0,
+        max_mmbtu_per_hour::Real = BIG_NUMBER,


We should use ton instead of mmbtu_per_hour for heat pump thermal production. That's how they typically state the capacity in the industry. So this should apply to min, max, installed cost, O&M cost, and any incentives which I see we don't have a generic $/ton or percent-based incentive currently.

I converted mmbtu to ton for ASHP capacity here 032e0d6

Bill-Becker · 2024-05-09T23:52:03Z

src/results/ashp.jl

+- `size_mmbtu_per_hour`  # Thermal production capacity size of the ASHP [MMBtu/hr]
+- `electric_consumption_series_kw`  # Fuel consumption series [kW]
+- `annual_electric_consumption_kwh`  # Fuel consumed in a year [kWh]
+- `thermal_production_series_mmbtu_per_hour`  # Thermal energy production series [MMBtu/hr]


Related but counter to changing the sizing capacity/basis to ton, I'm not opposed to reporting heating load production as mmbtu/hr because that's how we have other heating results. Let's just make sure we're using the same naming convention for thermal/heating/cooling results as other heating and cooling techs, like CHP and GHP. I think this is consistent, and we're differentiating between heating production and cooling production based on the units.

Addressed here 032e0d6

Bill-Becker · 2024-05-09T23:52:48Z

src/results/ashp.jl

+
+function add_ashp_results(m::JuMP.AbstractModel, p::REoptInputs, d::Dict; _n="")
+    r = Dict{String, Any}()
+    r["size_mmbtu_per_hour"] = round(value(m[Symbol("dvSize"*_n)]["ASHP"]) / KWH_PER_MMBTU, digits=3)


Is this size based on the peak coincident heating and cooling thermal production?

yes - see the constraint here:

function add_ashp_heating_cooling_constraints(m, p; _n="") @constraint(m, [t in setdiff(intersect(p.techs.cooling, p.techs.heating), p.techs.ghp), ts in p.time_steps], sum(m[Symbol("dvHeatingProduction"*_n)][t,q,ts] for q in p.heating_loads) + m[Symbol("dvCoolingProduction"*_n)][t,ts] <= m[Symbol("dvSize"*_n)][t] ) end

Bill-Becker · 2024-05-09T23:55:40Z

test/runtests.jl

@@ -2297,6 +2297,56 @@ else  # run HiGHS tests

        end

+        @testset "ASHP" begin
+            #Case 1: Boiler produces the required heat instead of ASHP - ASHP is not purchased


Do we have an equivalent way to "force in space heating ASHP", like we do for GHP, right now? I think the new ExistingBoiler.retire_in_optimal would "force in space heating and DHW ASHP", but we don't have a way to just force in "DHW ASHP".

I guess it would be setting the min size, but in order to do that accurately you'd have to know what the peak heating or coincident peak heating + cooling thermal load.

Would the force-in function set set all other heating production variables to zero, i.e., would we allow only ASHP to be the source of a given heating load? I ask because we'd also probably exclude other possible techs like the CHP from providing heat as well. (And, if we do this, does that mean no storage as well? CHP would serve load using storage as a middleman otherwise.)

Bill-Becker · 2024-05-09T23:57:33Z

test/test_with_cplex.jl

@@ -163,6 +163,45 @@ end
    @test r["ElectricTariff"]["year_one_demand_cost_before_tax"] ≈ expected_demand_cost
 end

+@testset "ASHP" begin
+    d = JSON.parsefile("./scenarios/ashp.json")


Is someone currently testing with CPLEX?!

Deleted this. I performed this test for my own only but accidentally pushed it.

Bill-Becker · 2024-05-09T23:58:11Z

test/test_with_xpress.jl

+@testset "ASHP" begin
+    d = JSON.parsefile("./scenarios/ashp.json")
+    d["SpaceHeatingLoad"]["annual_mmbtu"] = 0.5 * 8760
+    d["DomesticHotWaterLoad"]["annual_mmbtu"] = 0.5 * 8760
+    s = Scenario(d)
+    p = REoptInputs(s)
+    m = Model(optimizer_with_attributes(Xpress.Optimizer, "OUTPUTLOG" => 0))
+    results = run_reopt(m, p)
+
+    #first run: Boiler produces the required heat instead of ASHP - ASHP is not purchased here
+    @test results["ASHP"]["size_mmbtu_per_hour"] ≈ 0.0 atol=0.1
+    @test results["ASHP"]["annual_thermal_production_mmbtu"] ≈ 0.0 atol=0.1
+    @test results["ASHP"]["annual_electric_consumption_kwh"] ≈ 0.0 atol=0.1
+    @test results["ElectricUtility"]["annual_energy_supplied_kwh"] ≈ 87600.0 atol=0.1
+
+    d["ExistingBoiler"]["fuel_cost_per_mmbtu"] = 100
+    d["ASHP"]["installed_cost_per_mmbtu_per_hour"] = 1.0
+    d["ElectricTariff"]["monthly_energy_rates"] = [0,0,0,0,0,0,0,0,0,0,0,0]
+    s = Scenario(d)
+    p = REoptInputs(s)
+    m = Model(optimizer_with_attributes(Xpress.Optimizer, "OUTPUTLOG" => 0))
+    results = run_reopt(m, p)
+
+    annual_thermal_prod = 0.8 * 8760  #80% efficient boiler --> 0.8 MMBTU of heat load per hour
+    annual_ashp_consumption = annual_thermal_prod * REopt.KWH_PER_MMBTU  #1.0 COP
+    annual_energy_supplied = 87600 + annual_ashp_consumption
+
+    #Second run: ASHP produces the required heat with free electricity
+    @test results["ASHP"]["size_mmbtu_per_hour"] ≈ 0.8 atol=0.1
+    @test results["ASHP"]["annual_thermal_production_mmbtu"] ≈ annual_thermal_prod rtol=1e-4
+    @test results["ASHP"]["annual_electric_consumption_kwh"] ≈ annual_ashp_consumption rtol=1e-4
+    @test results["ElectricUtility"]["annual_energy_supplied_kwh"] ≈ annual_energy_supplied rtol=1e-4
+
+end
+


Yes, we should be doing all tests in HiGHS, and we don't need to add to test_with_xpress.jl.

@atpham88

cc @atpham88 Co-Authored-By: An Pham <An.Pham@nrel.gov>

…nctions for API

atpham88 added 24 commits February 20, 2024 17:11

added ASHP defaults

26e7e26

added ashp defaults

45461c9

added ashp to results

424e871

added ashp to load balance

9db934b

check electric heater's cop to backup_heating_cop

2f42237

added ASHP for heating

18fb79d

added testing file for ashp

52d751d

tested ASHP with cplex

3955266

test ashp with cplex

83820cc

add default ASHP COP

586a656

Update techs.jl

771efee

Update scenario.jl

fa5f2a2

Merge branch 'add-process-heat-load' into add-ASHP

08cf76a

Update ashp.jl

3510dce

separated heating and cooling COPs

3aa1105

fix minor name error

ccc7827

minor name changes

9ae9fee

add heating COP curve for ASHP

ab5b5c7

add ashp COP curve

1c4ddb7

add ASHP COP curves

50748b6

Merge branch 'add-process-heat-load' into add-ASHP

eaef40a

tested new ASHP COP curves

e94c6b3

updated linear ASHP COP curve

ce8cae0

update defaults using Grant's numbers

6d606fb

atpham88 requested a review from zolanaj April 8, 2024 16:05

zolanaj added 5 commits April 22, 2024 10:45

Merge branch 'add-process-heat-load' into add-ASHP

a1cbf4d

Merge branch 'add-process-heat-load' into add-ASHP

83fc4bf

add empty ashp_techs field to MPC Techs object

608cece

rm cop from docstrings

1fce129

allow nothing for ASHP load-serving booleans

9536fa3

zolanaj added 4 commits April 28, 2024 11:21

update ASHP tests

e7b92b5

fix ExistingChiller default COP assignment

f71b5b5

update sets for ASHP constraints to exclude GHP

6347211

default cooling and heating COPs for GHP formulation

04de091

zolanaj requested a review from Bill-Becker April 29, 2024 21:38

zolanaj reviewed Apr 29, 2024

View reviewed changes

atpham88 and others added 6 commits April 30, 2024 12:02

minor clean up

3c23e46

Merge branch 'add-ASHP' of https://github.com/NREL/REopt.jl into add-…

3391569

…ASHP

Revert "Merge branch 'add-ASHP' of https://github.com/NREL/REopt.jl i…

21750e0

…nto add-ASHP" This reverts commit 3391569, reversing changes made to 3c23e46.

cooling_cop, heating_cop for GHP

22c0a57

update sets for add_ashp_heating_cooling_constraints

2c12c6b

Add ASHP docs

d21b6d7

Bill-Becker reviewed May 9, 2024

View reviewed changes

zolanaj added 4 commits May 10, 2024 13:59

Merge branch 'develop' into add-ASHP

61b70ed

update tech max sizes to use time-series COPs

1bba5dd

rm note on process heat loads (which are now in fuel input)

0c763e6

update notes for heating loads in documentation

0b1683e

zolanaj changed the base branch from add-process-heat-load to develop May 14, 2024 03:20

zolanaj and others added 3 commits May 14, 2024 07:53

rm tests for ASHP in cplex and xpress

05bcdc0

add todo for cooling COP review

dc8d326

cc @atpham88 Co-Authored-By: An Pham <An.Pham@nrel.gov>

convert ASHP size from mmbtu to ton

032e0d6

atpham88 changed the title ~~Added ASHP (for space heating)~~ Added ASHP (for space heating & cooling) May 23, 2024

atpham88 and others added 7 commits May 23, 2024 19:46

updated ashp test

2e7b6c4

ren ton_per_hour ton (which is a rate)

03f7172

convert cost conversions to reflect ASHP size in tons

4b3d670

update ASHP test units

2ee2645

add get_electric_heater_defaults and get_ashp_defaults to exported fu…

55f5dc5

…nctions for API

docstrings update for ASHP

ab0d73c

update units in ashp test

3ea9714

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ASHP (for space heating & cooling) #372

Added ASHP (for space heating & cooling) #372

atpham88 commented Apr 8, 2024 •

edited

zolanaj commented Apr 29, 2024

zolanaj left a comment

zolanaj Apr 29, 2024

zolanaj Apr 29, 2024

Bill-Becker May 9, 2024

Bill-Becker left a comment

Bill-Becker May 9, 2024

atpham88 May 23, 2024

Bill-Becker May 9, 2024

atpham88 May 23, 2024

Bill-Becker May 9, 2024

zolanaj May 14, 2024

Bill-Becker May 9, 2024

Bill-Becker May 9, 2024

zolanaj May 14, 2024

Bill-Becker May 9, 2024

atpham88 May 23, 2024

Bill-Becker May 9, 2024

		heating_cop::Dict{String, Array{<:Real, 1}} # (techs.ashp)
		cooling_cop::Dict{String, Array{<:Real, 1}} # (techs.ashp)

Added ASHP (for space heating & cooling) #372

Are you sure you want to change the base?

Added ASHP (for space heating & cooling) #372

Conversation

atpham88 commented Apr 8, 2024 • edited

Notes

zolanaj commented Apr 29, 2024

zolanaj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bill-Becker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atpham88 commented Apr 8, 2024 •

edited