Add battery O&M and self-discharge #354
Conversation
lixiangk1
commented
Feb 29, 2024
•
lixiangk1
commented
- Add battery O&M in $ / kW-installed and $ / kWh-installed, defaulted to $0
- Add battery self-discharge as a fraction per day loss based on stored kWh, defaulted to 0.0
| @@ -164,6 +166,7 @@ end | |||
| model_degradation::Bool = false | |||
| degradation::Dict = Dict() | |||
| minimum_avg_soc_fraction::Float64 = 0.0 | |||
| daily_self_discharge_fraction::Float64 = 0.0 | |||
There was a problem hiding this comment.
@lixiangk1 could you add a little explanatory text here for this input?
There was a problem hiding this comment.
Hey! Did you mean add notes in the code to better define this term or just explain it in the pull request?
The input is a loss term for battery self-discharge, entered as a daily fraction for how much of the stored kWh is leaked from the battery (e.g., 3% of the the kWh stored in the battery is self-discharged per day). This is then modeled as a per timestep loss term where eg. 0.03/24/timesteps_per_hour * dvStoredEnergy is subtracted from dvStoredEnergy at every timestep.
There was a problem hiding this comment.
I mean adding a comment "# explanation" in the code here so that it appears in the REopt.jl documentation (https://nrel.github.io/REopt.jl/dev/reopt/inputs/#ElectricStorage). We haven't really done this for ElectricStorage inputs but for all of the other techs we've been including some help text around the inputs. If you could do the same for the O&M costs that would be great! Maybe with a note about not double-counting replacement and O&M costs.
|
@lixiangk1 Three quick comments from an initial review!
|
|
@adfarth Thanks for your review! Do the latest changes address your comments? As for the tests, it seems that the Windows/MacOS ones are passing but the Ubuntu ones timeout - do you know why that might be happening? Is it something specific to this branch? |
Recapping our convo here!
|
