Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit battery storage duration #332

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Conversation

atpham88
Copy link
Collaborator

@atpham88 atpham88 commented Dec 1, 2023

Summary

This PR adds user-input option to limit the hour duration for battery storage.

Implementation notes

Changes in this PR to add this option:

1. electric_storage.jl: added a max_duration_hours input, default is 30 (hours), and min_duration_hours, default is 0 (hour). This defaults can be changed in ["ElectricStorage"]["max_duration_hours"] and ["ElectricStorage"]["min_duration_hours"]. For ex:

input["ElectricStorage"]["max_duration_hours"] = 8
input["ElectricStorage"]["min_duration_hours"] = 2

2. storage_constraints.jl: Add a constraint to limit battery energy capacity <= battery power rating * max_duration_hours and battery energy capacity >= battery power rating * min_duration_hours
https://github.com/NREL/REopt.jl/blob/limit_battery_energy_cap/src/constraints/storage_constraints.jl#L26

@adfarth
Copy link
Collaborator

adfarth commented Feb 7, 2024

@atpham88 I changed the new input name from battery_hours to max_duration_hours to indicate that it's an upper bound and not fixing the duration to a certain hours.

Could you:

  • Update the CHANGELOG file with a description of these changes
  • Make sure all highs tests pass (they're running now)
  • Make sure all xpress tests pass by running these locally (I can show how to do this if needed!)

@adfarth adfarth self-requested a review March 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants