-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit battery storage duration #332
Open
atpham88
wants to merge
19
commits into
develop
Choose a base branch
from
limit_battery_energy_cap
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bill-Becker
force-pushed
the
limit_battery_energy_cap
branch
from
January 30, 2024 04:13
6073760
to
d37dafb
Compare
Bill-Becker
force-pushed
the
limit_battery_energy_cap
branch
from
January 30, 2024 04:46
d37dafb
to
adcfdc6
Compare
@atpham88 I changed the new input name from Could you:
|
otherwise, if min is > max, size will just be set to zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds user-input option to limit the hour duration for battery storage.
Implementation notes
Changes in this PR to add this option:
1. electric_storage.jl: added a
max_duration_hours
input, default is 30 (hours), andmin_duration_hours
, default is 0 (hour). This defaults can be changed in["ElectricStorage"]["max_duration_hours"]
and["ElectricStorage"]["min_duration_hours"]
. For ex:2. storage_constraints.jl: Add a constraint to limit battery energy capacity <= battery power rating * max_duration_hours and battery energy capacity >= battery power rating * min_duration_hours
https://github.com/NREL/REopt.jl/blob/limit_battery_energy_cap/src/constraints/storage_constraints.jl#L26