Update electric_storage.jl and doc strings #106

rathod-b · 2022-07-26T18:37:41Z

Update default degradation parameters per updated parameters.

Also update several doc strings for input descriptions.

adfarth · 2022-07-28T21:36:49Z

I piggy backed on this PR to include a few minor updates to doc strings!

zolanaj

@rathod-b Looks good, thanks for these updates: A few comments beyond the in-line ones:

The docs for the degradation model still need to be updated; there are TODOs in the code but we might want that as an open issue just so we don't forget it.
It would be good to make a more robust collection of tests. We can use the new file degradation_tests.json for this since it's not currently used. We should include a test case for replacement (which we already have, but please add an assertion for the number of replacements or a new degradation-specific measure) and a test case for augmentation (which we don't have yet).

Let me know if you want help with any of these. Thanks!
Alex

src/core/energy_storage/electric_storage.jl

test/scenarios/degradation_tests.json

src/constraints/battery_degradation.jl

src/results/electric_storage.jl

src/constraints/battery_degradation.jl

rathod-b · 2022-09-07T15:19:57Z

src/constraints/battery_degradation.jl

+        @variable(m, bmth[months], Bin) # track which month SOH indicator drops to < 80%
+        @variable(m, 0 <= bmth_BkWh[months]) # track the kwh replacement value
+
+        M = 10*maximum(p.s.electric_load.loads_kw)  # the big M


Note: Current big-M. This value seems to be giving good consistent results. Rationale is that a battery wont be larger than the peak load so 10x peak load is large enough. Even this value might be larger than expected. @zolanaj should we sweep across a range of big M values (i.e. 0.1x, 1.0x, 10x peak load) to fine tune this parameter?

@rathod-b I checked the API and we never introduced a practical maximum size for batteries because they didn't have integer variables involved prior to the introduction of degradation.

One heuristic would be power = 2x peak load, and energy = 12x peak load (i.e., allowing you to charge for half the day, and discharge for the other half of the day). This precludes long-term storage systems, but we can probably include a user setting for long-term storage.

Related: I'll check our issues for importing big-M's from the API Julia code and add that issue if it's not there.

big-M issue is here: #114

Actually, a system that has oversized PV to power the site load might need more. just do 24x peak load for both power and energy, that should be enough.

Updated big-M to be set based on max_kwh. Is it normal for changes in big-M to change the results? I see slight differences in electric storage results.

rathod-b · 2022-09-08T00:12:13Z

test/test_with_xpress.jl

@@ -400,6 +400,44 @@ check to make sure that PV does NOT export unless the site load is met first for
              if results["PV"]["year_one_to_grid_series_kw"][i] > 0)
 end

+@testset "Battery degradation replacement strategy" begin


@zolanaj I added this test to test the outputs as well as model expression values. Since solve time is not an issue I am sticking with a simple LargeOffice load profile.

I had to change the result JSON tests to inequalities because we get different results on github action than those when testing this scenario by itself.

@rathod-b some values like the SOH indicator at the end are going to be stable while a lot of these others will change with solver settings. We can construct a more unit-test-like load profile to incentivize a certain behavior and make the solution more stable (something like a flat load with hourly cost that oscillates from very expensive to free every other period.)

rathod-b · 2023-02-25T18:56:48Z

@rathod-b Looks good, thanks for these updates: A few comments beyond the in-line ones:

The docs for the degradation model still need to be updated; there are TODOs in the code but we might want that as an open issue just so we don't forget it.

It would be good to make a more robust collection of tests. We can use the new file degradation_tests.json for this since it's not currently used. We should include a test case for replacement (which we already have, but please add an assertion for the number of replacements or a new degradation-specific measure) and a test case for augmentation (which we don't have yet).

Let me know if you want help with any of these. Thanks! Alex

Hi Alex, thanks for your comments on the PR! Its been a while and I am picking this back up. I have removed the many TODOs from the code documentation which were initially added as reminders for me. If you see any more of them, do let me know.

I have also updated the replacement strategy testset to validate some degradation specific parameters to ensure the results make sense and DVs arent switching between 0 and 1 as they were when we were testing this back in Fall 2022. Let me know if there are any comments on that.

Lastly, I have an open question for you. At present, we add the SOC incentive to the objective function in run_reopt.jl without any consideration for BESS degradation. I was wondering if we wanted to handle that programmatically, or handle it via a warning to a user and have then set the add_soc_incentive to false when running degradation?

rathod-b · 2023-02-25T18:59:08Z

@rathod-b Looks good, thanks for these updates: A few comments beyond the in-line ones:

The docs for the degradation model still need to be updated; there are TODOs in the code but we might want that as an open issue just so we don't forget it.

It would be good to make a more robust collection of tests. We can use the new file degradation_tests.json for this since it's not currently used. We should include a test case for replacement (which we already have, but please add an assertion for the number of replacements or a new degradation-specific measure) and a test case for augmentation (which we don't have yet).

Let me know if you want help with any of these. Thanks! Alex

Hi Alex, thanks for your comments on the PR! Its been a while and I am picking this back up. I have removed the many TODOs from the code documentation which were initially added as reminders for me. If you see any more of them, do let me know.

I have also updated the replacement strategy testset to validate some degradation specific parameters to ensure the results make sense and DVs arent switching between 0 and 1 as they were when we were testing this back in Fall 2022. Let me know if there are any comments on that.

Lastly, I have an open question for you. At present, we add the SOC incentive to the objective function in run_reopt.jl without any consideration for BESS degradation. I was wondering if we wanted to handle that programmatically, or handle it via a warning to a user and have then set the add_soc_incentive to false when running degradation?

I could also use some help in fixing the rendering of a formula in documentation. Line 145 in electric_storage.jl has the broken formula for residual value.

zolanaj · 2023-06-02T18:25:27Z

src/constraints/battery_degradation.jl

+            residual_factor = 1 - (p.s.financial.analysis_years*12/mth - floor(p.s.financial.analysis_years*12/mth))
+            residual_value = p.s.storage.attr[b].degradation.maintenance_cost_per_kwh[end]*residual_factor
+            s[mth] = residual_value

        end

-        #=
-        -> linearize the product of bmth & m[:dvStorageEnergy][b]
-        For all months
-            0 <= bmth_BkWh <= dvStorageEnergy <= M (when bmth is true)
-
-            if bmth is 0, bmth_BkWh = 0. if bmth is 1, bmth_BkWh can equal m[:dvStorageEnergy][b]
-        =# 
-        M = p.s.storage.attr[b].max_kwh  # the big M
-        @variable(m, 0 <= bmth_BkWh[months])
-        @constraint(m, [mth in months], bmth_BkWh[mth] <= m[:dvStorageEnergy][b])
-        @constraint(m, [mth in months], bmth_BkWh[mth] <= M * bmth[mth])
-        @constraint(m, [mth in months], bmth_BkWh[mth] >= m[:dvStorageEnergy][b] - M*(1-bmth[mth]))
-
-        # add replacment cost to objective
+        # create replacement cost expression for objective
        @expression(m, degr_cost, sum(c[mth] * bmth_BkWh[mth] for mth in months))

-        # create salvage value expression for objective
-        @expression(m, salv_value, sum(s[mth] * bmth_BkWh[mth] for mth in months))
+        # create residual value expression for objective
+        @expression(m, residual_value, sum(s[mth] * bmth_BkWh[mth] for mth in months))


is maintenance_cost_per_kwh actually a replacement cost? we may want to rename it for clarity (so itn's not confused with O&M costs).

zolanaj · 2023-06-02T18:28:39Z

test/test_with_xpress.jl

@@ -400,6 +400,44 @@ check to make sure that PV does NOT export unless the site load is met first for
              if results["PV"]["year_one_to_grid_series_kw"][i] > 0)
 end

+@testset "Battery degradation replacement strategy" begin


@rathod-b some values like the SOH indicator at the end are going to be stable while a lot of these others will change with solver settings. We can construct a more unit-test-like load profile to incentivize a certain behavior and make the solution more stable (something like a flat load with hourly cost that oscillates from very expensive to free every other period.)

zolanaj · 2023-06-02T18:31:05Z

@rathod-b Looks good, thanks for these updates: A few comments beyond the in-line ones:

The docs for the degradation model still need to be updated; there are TODOs in the code but we might want that as an open issue just so we don't forget it.

It would be good to make a more robust collection of tests. We can use the new file degradation_tests.json for this since it's not currently used. We should include a test case for replacement (which we already have, but please add an assertion for the number of replacements or a new degradation-specific measure) and a test case for augmentation (which we don't have yet).

Let me know if you want help with any of these. Thanks! Alex

Hi Alex, thanks for your comments on the PR! Its been a while and I am picking this back up. I have removed the many TODOs from the code documentation which were initially added as reminders for me. If you see any more of them, do let me know.
I have also updated the replacement strategy testset to validate some degradation specific parameters to ensure the results make sense and DVs arent switching between 0 and 1 as they were when we were testing this back in Fall 2022. Let me know if there are any comments on that.
Lastly, I have an open question for you. At present, we add the SOC incentive to the objective function in run_reopt.jl without any consideration for BESS degradation. I was wondering if we wanted to handle that programmatically, or handle it via a warning to a user and have then set the add_soc_incentive to false when running degradation?

I could also use some help in fixing the rendering of a formula in documentation. Line 145 in electric_storage.jl has the broken formula for residual value.

Lastly, I have an open question for you. At present, we add the SOC incentive to the objective function in run_reopt.jl without any consideration for BESS degradation. I was wondering if we wanted to handle that programmatically, or handle it via a warning to a user and have then set the add_soc_incentive to false when running degradation?

A warning should be fine here - these different objectives can be handled by the solver.

zolanaj

@rathod-b I made the degradation test a bit simpler and did some renaming of parameters and variables for style and clarity. If you agree with these and tests pass, I think this can be merged. (The HiGHS tests are timing out but I think everything else is passing.)

Update CHP defaults, and update Julia dependencies

…into add-electric-heater

…Eopt.jl into migrate-tests-from-xpress

…lity or non-compatibility

…Eopt.jl into migrate-tests-from-xpress

Add execute permissions to ssc.dll for Wind on Windows

Migrate tests from Xpress to HiGHS

Migrate Xpress tests to HiGHS, Fix Wind on Windows OS

…egradation

rathod-b requested a review from zolanaj July 26, 2022 18:39

adfarth changed the title ~~Update electric_storage.jl~~ Update electric_storage.jl and doc strings Aug 1, 2022

zolanaj requested changes Sep 1, 2022

View reviewed changes

src/core/energy_storage/electric_storage.jl Show resolved Hide resolved

test/scenarios/degradation_tests.json Outdated Show resolved Hide resolved

src/constraints/battery_degradation.jl Outdated Show resolved Hide resolved

src/results/electric_storage.jl Show resolved Hide resolved

rathod-b commented Sep 7, 2022

View reviewed changes

src/constraints/battery_degradation.jl Show resolved Hide resolved

rathod-b commented Sep 7, 2022

View reviewed changes

rathod-b commented Sep 8, 2022

View reviewed changes

zolanaj reviewed Jun 2, 2023

View reviewed changes

zolanaj self-requested a review June 16, 2023 15:48

zolanaj approved these changes Jun 16, 2023

View reviewed changes

Bill-Becker and others added 17 commits October 11, 2023 11:26

Merge pull request #291 from NREL/develop

cd92134

Update CHP defaults, and update Julia dependencies

Update version in Project.toml and CHANGELOG.md

4e08fe2

starter code for electric_heater struct

8f02f13

techs setup for electric heaters

ae2ca90

include electric_heater.jl in REopt.jl

8a36f31

include electric_heater.jl in REopt.jl

452f7dd

scenario setup for ElectricHeater

3a842e8

Merge branch 'add-electric-heater' of https://github.com/NREL/REopt.jl …

bc51fea

…into add-electric-heater

rm duplicate include and fix syntax

7f35111

Update Electrical Load Balance Constraints for Electric Heater

3edf337

Update types to include electric heater

c8e5ebc

remove om_cost_per_kwh, ren cop_heating heating_cop

4c6fc43

Set up electric heater in REoptInputs

1175c82

Add electric heater results

46ae908

fix: rm ElectricHeater from steam_turbines Techs

11e4244

rename electric heater default data file

894c9c9

Add heating_cop to BAUInputs

ac89522

zolanaj and others added 25 commits December 11, 2023 17:45

Merge branch 'migrate-tests-from-xpress' of https://github.com/NREL/R…

868f7b3

…Eopt.jl into migrate-tests-from-xpress

import DelimitedFiles and Random for GHP, FlexibleHVAC tests

c15c3d5

update CHP test values

9da2b76

add presolve option to trigger incompatibility

9984261

replace xpress solver settings with HiGHS

bf0c85f

update wind tests for incompatible solver

8aeaa1d

rm test result query from incompatible test

e7d93f3

include infeasible/non-optimal result in FlexibleHVAC tests

b59f538

recover offgrid and GHP tests

f352634

allow infeasible or suboptimal error for wind outages test

78d8352

use string conversion of errors in results when looking for infeasibi…

1799ee7

…lity or non-compatibility

use string conversion of errors in results when looking for infeasibi…

3581734

…lity or non-compatibility

Merge branch 'migrate-tests-from-xpress' of https://github.com/NREL/R…

49d3729

…Eopt.jl into migrate-tests-from-xpress

fix string references in new tests

6b5f50a

Update CHANGELOG.md

a2f7a16

Add execute permissions to ssc.dll for Wind on Windows

3f64ed8

Merge pull request #340 from NREL/ssc-dll-permissions

2bd7732

Add execute permissions to ssc.dll for Wind on Windows

Update CHANGELOG.md with fix

3d43ae4

Create broken_tests.txt

1dbf4ce

Merge branch 'develop' into migrate-tests-from-xpress

aaa676e

Merge pull request #339 from NREL/migrate-tests-from-xpress

f883c8d

Migrate tests from Xpress to HiGHS

Merge pull request #341 from NREL/develop

372cb54

Migrate Xpress tests to HiGHS, Fix Wind on Windows OS

Update to new version v0.39.1

643c70d

Merge branch 'develop' into degradation

2cffed5

Merge branch 'develop' into degradation

0385d5b

Bill-Becker force-pushed the degradation branch from 0385d5b to e78db43 Compare January 30, 2024 04:13

Bill-Becker force-pushed the develop branch 2 times, most recently from b77814e to b528862 Compare January 30, 2024 04:46

Bill-Becker force-pushed the degradation branch from e78db43 to 2cffed5 Compare January 30, 2024 04:46

Merge branch 'degradation' of https://github.com/NREL/REopt.jl into d…

74f3f94

…egradation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update electric_storage.jl and doc strings #106

Update electric_storage.jl and doc strings #106

rathod-b commented Jul 26, 2022 •

edited by adfarth

adfarth commented Jul 28, 2022 •

edited

zolanaj left a comment

rathod-b Sep 7, 2022

zolanaj Sep 7, 2022

zolanaj Sep 7, 2022

zolanaj Sep 7, 2022

rathod-b Sep 8, 2022

rathod-b Sep 8, 2022

zolanaj Jun 2, 2023

rathod-b commented Feb 25, 2023

rathod-b commented Feb 25, 2023

zolanaj Jun 2, 2023

zolanaj Jun 2, 2023

zolanaj commented Jun 2, 2023

zolanaj left a comment

Update electric_storage.jl and doc strings #106

Are you sure you want to change the base?

Update electric_storage.jl and doc strings #106

Conversation

rathod-b commented Jul 26, 2022 • edited by adfarth

adfarth commented Jul 28, 2022 • edited

zolanaj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rathod-b commented Feb 25, 2023

rathod-b commented Feb 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zolanaj commented Jun 2, 2023

zolanaj left a comment

Choose a reason for hiding this comment

rathod-b commented Jul 26, 2022 •

edited by adfarth

adfarth commented Jul 28, 2022 •

edited