Improve net-metering big-m constraint #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
post-discussion changes:
|
|
Mac tests seem to be stalling out but things are working fine in the Windows test suite! |
adfarth
approved these changes
May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Improved the practical upper bound on interconnect limit for net metering constraints. Prevents erroneous results in which net metering limit is exceeded and net metering benefit is still gained.
Added
New tests for net metering added.
one comment: there's a max benefit of 10 times the annual energy charges which is reached if the wholesale rate provided is larger than the energy price. One question is: should we throw a warning if the results hit this max benefit?