Skip to content

Commit

Permalink
Increase loop low flow tolerance.
Browse files Browse the repository at this point in the history
  • Loading branch information
lymereJ committed Apr 4, 2024
1 parent ed759b1 commit 4a18f3e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/EnergyPlus/DataConvergParams.hh
Expand Up @@ -92,8 +92,7 @@ namespace DataConvergParams {
constexpr Real64 PlantEnergyToler(10.0); // Tolerance for Energy comparisons (in Watts W)

// Energy Tolerance Calculation, used to scale the answer for a more intuitive answer for comparison
constexpr Real64 PlantFlowFlowRateToler(0.01); // Tolerance for mass flow rate convergence (in kg/s)
constexpr Real64 PlantLowFlowRateToler(0.000001); // Tolerance for low flow rate used for determining when plant pumps can be shut down
constexpr Real64 PlantFlowFlowRateToler(0.01); // Tolerance for mass flow rate convergence (in kg/s)

constexpr int ConvergLogStackDepth(10);

Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/Plant/LoopSide.cc
Expand Up @@ -1177,7 +1177,7 @@ namespace DataPlant {

// overrides the loop solver flow request to allow loop pump to turn off when not in use
if (this_loop_side.TotalPumps == 1) {
if (LoopFlow < DataConvergParams::PlantLowFlowRateToler) { // Update from dataconvergetols...
if (LoopFlow < DataHVACGlobals::VerySmallMassFlow) { // Update from dataconvergetols...
for (int BranchCounter = 1; BranchCounter <= this_loop_side.TotalBranches; ++BranchCounter) {
// reference
auto &branch(this_loop_side.Branch(BranchCounter));
Expand Down

2 comments on commit 4a18f3e

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22.1_low_flow_tol_fix (lymereJ) - Win64-Windows-10-VisualStudio-16: Build Failed

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22.1_low_flow_tol_fix (lymereJ) - x86_64-MacOS-10.18-clang-15.0.0: Build Failed

Failures:\n

API Test Summary

  • Failed: 10
  • notrun: 5

integration Test Summary

  • Passed: 2
  • Failed: 742

Build Badge Test Badge

Please sign in to comment.