Add CSI, FAR, Hit Rate evaluation plot to MONET #247
Conversation
Conflicts: melodies_monet/driver.py melodies_monet/plots/surfplots.py
There was a problem hiding this comment.
This works, for describing the yaml file updates and for adding this plot into an example! I suggested one typo update. My largest concern is you have a lot of BACKUP files you are trying to add. Can we remove these? I don't think we need to keep track of them in the main code, but I agree it is useful for you as you are doing the code development to keep copies of these backup files on your own system.
docs/appendix/yaml.rst
Outdated
| **model_name_list:** multi-box plot only. list of observation and model names user choose to set as x-labels | ||
| **model_name_list:** | ||
| for multi-box plot, list of observation and model names user choose to set as x-labels; | ||
| for csi plot, list of mode names (only) user choose to set as labels. |
There was a problem hiding this comment.
Should it be "model" here instead of mode?
| @@ -0,0 +1,1595 @@ | |||
| # Copyright (C) 2022 National Center for Atmospheric Research and National Oceanic and Atmospheric Administration | |||
There was a problem hiding this comment.
Do we need to add these driver backup files to GitHub? What is their purpose?
| @@ -0,0 +1,1078 @@ | |||
| # Copyright (C) 2022 National Center for Atmospheric Research and National Oceanic and Atmospheric Administration | |||
There was a problem hiding this comment.
Do we need to keep track of these backup files on GitHub? I would prefer these just be in your own code for documentation, but we do not add it to the main GitHub repo.
melodies_monet/plots/surfplots.py
Outdated
| @@ -991,6 +1003,7 @@ def make_boxplot(comb_bx, label_bx, ylabel = None, vmin = None, vmax = None, out | |||
| savefig(outname + '.png', loc=4, logo_height=100) | |||
|
|
|||
| def make_multi_boxplot(comb_bx, label_bx,region_bx,region_list = None, model_name_list=None,ylabel = None, vmin = None, vmax = None, outname='plot', | |||
| >>>>>>> origin/develop | |||
There was a problem hiding this comment.
What does this line do? It looks like it may not need to be here.
change mode to models on line 334
delete useless line
|
@zmoon looks like the test_get_data_cli.py is failing right now. As this is unrelated to these code updates, fine to merge in for now. Zach do you know why this is failing? |
|
It's an error when trying to download AQS files from EPA, one that I haven't seen before ( |
I just create CSI, FAR, Hit Rate plot to be merge in MONET, please give a review @zmoon