Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing TROPOMI L2 NO2 data and plot #225

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mlirenzhenmayi
Copy link
Collaborator

Processing TROPOMI L2 NO2 data and plotting

# Copyright (C) 2022 National Center for Atmospheric Research and National Oceanic and Atmospheric Administration
# SPDX-License-Identifier: Apache-2.0

# calculate WRF-Chem NO2 trop. columns, for further pair with satellite swath data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only for WRF comparisons right now and you plan to generalize to more models later? Or should we call this python script cal_wrf_no2col.py?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for WRF right now. I'm not sure if this can be applied to other models. It should work but with several modifications such as variable names, etc. I think it does make sense to change it to cal_wrf_no2col.py.

@rrbuchholz
Copy link
Collaborator

rrbuchholz commented Mar 13, 2024

Hi Meng,
There are some conflicts in the driver - could you pull the latest version of the MELODIES MONET develop branch code to your fork and make sure they are harmonized?
Best,
Rebecca

@rrbuchholz
Copy link
Collaborator

@dwfncar : David I'm not sure what issues might be remaining in Meng's pull request. She harmonized the driver. Could you possibly take a look? Thanks!

@rrbuchholz
Copy link
Collaborator

P.S. @mlirenzhenmayi : Meng it looks like these might be the issue:
util/cal_mod_no2col.py doesn't have correct header
util/sat_l2_swath_utility.py doesn't have correct header

But thinking about these further... should this code be inside the: satellite_utilities.py file?
@dwfncar, @mebruckner : thoughts?

@rrbuchholz
Copy link
Collaborator

@mlirenzhenmayi - could you pull another two updates two your branch? There's one for driver.py and one for satplots.py.

@zmoon
Copy link
Collaborator

zmoon commented May 8, 2024

Looks like AERONET web server is currently being updated, causing a CI failure.

@rrbuchholz
Copy link
Collaborator

Hmmm, am wondering why we need the AERONET data for the TROPOMI satellite code?

@zmoon
Copy link
Collaborator

zmoon commented May 30, 2024

Hmmm, am wondering why we need the AERONET data for the TROPOMI satellite code?

It's a test of the get-aeronet tool. Not related to TROPOMI. But the tests run on every PR. I just re-ran and now they're passing again.

Note that the linter check is still failing since util/sat_l2_swath_utility.py and util/cal_mod_no2col.py don't have the license header yet.

@rrbuchholz
Copy link
Collaborator

rrbuchholz commented May 31, 2024

Thanks Zach!

I see maybe you added those license lines now to those files?
# Copyright (C) 2022 National Center for Atmospheric Research and National Oceanic and Atmospheric Administration
# SPDX-License-Identifier: Apache-2.0

Or is there something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants