Wrap C functions to throw errors in wrapper Lua functions #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes all C functions not throw their Lua errors directly, and instead makes them return it for a Lua wrapper to pick up and raise. By doing this, the issue of longjmp translation is bypassed/fixed on non-Windows platforms, as the errors are thrown and caught inside native Lua runtime code. Fixes NLua#344
|
Any updates on this / anything which needs to be changed before this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes all C functions not throw their Lua errors directly, and instead makes them return it for a Lua wrapper to pick up and raise. By doing this, the issue of longjmp translation is bypassed/fixed on non-Windows platforms, as the errors are thrown and caught inside native Lua runtime code.
Fixes #344