Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add twitter link to header #8490

Closed
wants to merge 1 commit into from

Conversation

AvaGanesh
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

There is no twitter/x link of the ng-zorro-antd twitter community in the official documentation

Issue Number: 5947 Issue - 5947 Adding twitter link to the header

What is the new behavior?

Added a twitter/x icon which redirects to https://twitter.com/ng_zorro

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (a27a47e) to head (ad67830).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8490      +/-   ##
==========================================
- Coverage   91.59%   91.59%   -0.01%     
==========================================
  Files         533      533              
  Lines       18391    18391              
  Branches     2808     2808              
==========================================
- Hits        16846    16845       -1     
- Misses       1227     1228       +1     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery
Copy link
Collaborator

Laffery commented Apr 12, 2024

@AvaGanesh Thank you for your contribution!
I'm wondering why we should put X in such an important position, what the benefit of doing so is? In fact, at the bottom of the site we have a list of links, including zorro's link in the twitter feed. I think it will be great if you would like to update this twitter link to X instead of adding it at the header:)
image

@AvaGanesh
Copy link
Author

@Laffery your suggestion makes sense, I will make the changes and issue a new PR.

@Laffery Laffery closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants