New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removed all usages of <color-sketch> #8465
refactor: removed all usages of <color-sketch> #8465
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8465 +/- ##
==========================================
- Coverage 91.57% 91.57% -0.01%
==========================================
Files 533 532 -1
Lines 18336 18334 -2
Branches 2801 2801
==========================================
- Hits 16792 16789 -3
- Misses 1226 1227 +1
Partials 318 318 ☔ View full report in Codecov by Sentry. |
Hi @ParsaArvanehPA , thanks to your nice contribution, I left some suggesions to remove useless styles and I hope this message finds you well :) |
Hi @Laffery , thank you for checking my PR. |
@ParsaArvanehPA I'm sorry about that, it's available now |
…r-picker # Conflicts: # package-lock.json # package.json
Changes have been made, thanks again for checking it out @Laffery |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently there are 2 usages of an external library called
color-sketch
in our codebase; one in the Watermark component, and another one in the footer of the doucment site.What is the new behavior?
Removed all usages of
color-sketch
and use Ng-zorro's built-in color picker.Does this PR introduce a breaking change?
Other information
Usages: