Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed all usages of <color-sketch> #8465

Merged

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Mar 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently there are 2 usages of an external library called color-sketch in our codebase; one in the Watermark component, and another one in the footer of the doucment site.

What is the new behavior?

Removed all usages of color-sketch and use Ng-zorro's built-in color picker.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Usages:

image

Copy link

zorro-bot bot commented Mar 25, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (81ef077) to head (b0d78d6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8465      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         533      532       -1     
  Lines       18336    18334       -2     
  Branches     2801     2801              
==========================================
- Hits        16792    16789       -3     
- Misses       1226     1227       +1     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 changed the title refactor(module:color-picker): removed all usages of <color-sketch> refactor: removed all usages of <color-sketch> Mar 29, 2024
@Laffery
Copy link
Collaborator

Laffery commented Apr 19, 2024

Hi @ParsaArvanehPA , thanks to your nice contribution, I left some suggesions to remove useless styles and I hope this message finds you well :)

@ParsaArvanehPA
Copy link
Contributor Author

Hi @ParsaArvanehPA , thanks to your nice contribution, I left some suggesions to remove useless styles and I hope this message finds you well :)

Hi @Laffery , thank you for checking my PR.
I think you forgot to submit your reviews because I don't see any requested changes.

@Laffery
Copy link
Collaborator

Laffery commented Apr 29, 2024

Hi @Laffery , thank you for checking my PR. I think you forgot to submit your reviews because I don't see any requested changes.

@ParsaArvanehPA I'm sorry about that, it's available now

@ParsaArvanehPA
Copy link
Contributor Author

Hi @Laffery , thank you for checking my PR. I think you forgot to submit your reviews because I don't see any requested changes.

@ParsaArvanehPA I'm sorry about that, it's available now

Changes have been made, thanks again for checking it out @Laffery

@Laffery Laffery merged commit 65cbb4e into NG-ZORRO:master May 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants