New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:menu): add click trigger for submenus #8461
Open
ParsaArvanehPA
wants to merge
13
commits into
NG-ZORRO:master
Choose a base branch
from
ParsaArvanehPA:feature/submenu-triggers
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(module:menu): add click trigger for submenus #8461
ParsaArvanehPA
wants to merge
13
commits into
NG-ZORRO:master
from
ParsaArvanehPA:feature/submenu-triggers
+74
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vanehPA/ng-zorro-antd into feature/submenu-triggers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8461 +/- ##
==========================================
+ Coverage 91.60% 91.62% +0.02%
==========================================
Files 519 530 +11
Lines 18074 18394 +320
Branches 2848 2813 -35
==========================================
+ Hits 16557 16854 +297
- Misses 1218 1224 +6
- Partials 299 316 +17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In Ant design, it is possible to choose between a
click
or ahover
trigger for submenues.Issue Number: #4745
What is the new behavior?
click
trigger implemented.Does this PR introduce a breaking change?
Other information