Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:calendar): change language can fresh show calendar text #8147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yangjianguo12
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ✔] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

当非路由改变语言时,日历组建的翻译内容更新

Issue Number: N/A

What is the new behavior?

当非路由行为切换语言时,日历组建可以正确切换语言

Does this PR introduce a breaking change?

[ ] Yes
[ ✔ ] No

Other information

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (50f6700) to head (818b3d7).
Report is 256 commits behind head on master.

❗ Current head 818b3d7 differs from pull request most recent head 50ccdec. Consider uploading reports for the commit 50ccdec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8147   +/-   ##
=======================================
  Coverage   91.69%   91.70%           
=======================================
  Files         517      517           
  Lines       17795    17798    +3     
  Branches     2724     2724           
=======================================
+ Hits        16318    16321    +3     
  Misses       1178     1178           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -101,6 +101,9 @@ export class NzCalendarHeaderComponent implements OnInit {
ngOnInit(): void {
this.setUpYears();
this.setUpMonths();
this.i18n.localeChange.subscribe(() => {
this.setUpMonths();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.i18n.localeChange is BehaviorSubject, so setUpMonths will be triggered twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants