Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust pipelines to properly run against qa pink regularly and other … #649

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

adjust pipelines to properly run against qa pink regularly and other … #649

wants to merge 10 commits into from

Conversation

ucvib
Copy link
Contributor

@ucvib ucvib commented Jul 21, 2023

…environments on deploys

Description

Checklist

  • Added proper unit tests
  • Left proper TODO messages for any remaining tasks
  • Scanned for web accessibility with aXe, and mitigated or documented
    flagged issues

Screenshots/Screen Recordings (if Appropriate)

@ucvib ucvib marked this pull request as ready for review July 21, 2023 16:36
craigrbarnes
craigrbarnes reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@craigrbarnes craigrbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. One question I have does the pipeline stop on the first timeout, as it considers this a failure. If not, is it possible that many calls all time out in one after the other, resulting in hours/days of a running pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigrbarnes craigrbarnes craigrbarnes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ucvib @craigrbarnes