Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEAR-1939 Update Manage Sets warning #1123

Merged
merged 1 commit into from
May 16, 2024

Conversation

wteouchicago
Copy link
Contributor

@wteouchicago wteouchicago commented May 15, 2024

Description

  • updates the warning in Manage Sets to be more congruent with how persistent sets may be

Checklist

  • [N/A] Added proper unit tests
  • [N/A] Left proper TODO messages for any remaining tasks
  • [N/A] Scanned for web accessibility with aXe, and mitigated or documented
    flagged issues

Screenshots/Screen Recordings (if Appropriate)

Screenshot 2024-05-14 at 10 58 22 PM

@wteouchicago
Copy link
Contributor Author

fyi @bpierce01 in case you want to update the text in your test when this PR lands: https://github.com/NCI-GDC/gdc-frontend-framework/blob/develop/holmes-py/specs/gdc_data_portal_v2/manage_sets/miscellaneous_and_negative_path.spec#L54

note that this text may change in the future

@craigrbarnes craigrbarnes merged commit 234c480 into develop May 16, 2024
4 checks passed
@craigrbarnes craigrbarnes deleted the PEAR-1939-update-manage-sets-text branch May 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants