PEAR-1900 expand files table search #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paribartandhakal
approved these changes
May 15, 2024
| @@ -483,7 +493,7 @@ const FilesTables: React.FC = () => { | |||
| search={{ | |||
| enabled: true, | |||
| tooltip: | |||
| "e.g. HCM-CSHL-0062-C18.json, 4b5f5ba0-3010-4449-99d4-7bd7a6d73422", | |||
| "e.g. HCM-CSHL-0062-C18.json, 4b5f5ba0-3010-4449-99d4-7bd7a6d73422, HCM-CSHL-0062-C18", | |||
There was a problem hiding this comment.
Nitpick: I'm not sure how often this will change or how many places will use it. If we make this a constant and import it, we can easily update it in one place later if needed.
There was a problem hiding this comment.
so this specific text will be used in 2 files table. each search "tooltip" will have different text depending on what search is possible. not sure if 2 is sufficient to make a const out of it. 🤷♀️ any idea? @paribartandhakal
There was a problem hiding this comment.
Okay it makes sense if that's the case. We can leave as is.
craigrbarnes
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
flagged issues
Screenshots/Screen Recordings (if Appropriate)