Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEAR-1926: Allow negative age in days to be converted to years and days readable format. #1121

Merged
merged 2 commits into from
May 17, 2024
Merged

PEAR-1926: Allow negative age in days to be converted to years and days readable format. #1121

merged 2 commits into from
May 17, 2024

Conversation

paribartandhakal
Copy link
Contributor

@paribartandhakal paribartandhakal commented May 13, 2024 •
edited

Description

Cleaned up the function to make it simple also.

Checklist

  • Added proper unit tests
  • [N/A] Left proper TODO messages for any remaining tasks
  • [N/A] Scanned for web accessibility with aXe, and mitigated or documented
    flagged issues

Screenshots/Screen Recordings (if Appropriate)

BEFORE
Screenshot 2024-05-13 at 5 30 06 PM

AFTER
Screenshot 2024-05-13 at 5 29 15 PM

@wteouchicago
Copy link
Contributor

looks good to me -- evgeniia can test more when it's merged. 👍

craigrbarnes
craigrbarnes approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@craigrbarnes craigrbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine. This code is now more understandable.

@craigrbarnes craigrbarnes merged commit 5722111 into develop May 17, 2024
4 checks passed
@craigrbarnes craigrbarnes deleted the bugfix/pear-1926-negative-days-years branch May 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigrbarnes craigrbarnes craigrbarnes approved these changes

@amlehman amlehman amlehman approved these changes

@wteouchicago wteouchicago Awaiting requested review from wteouchicago

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paribartandhakal @wteouchicago @craigrbarnes @amlehman