(PEAR-1586): Update Mantine to 7 #1113

ocshawn · 2024-05-08T14:32:27Z

Description

Update:
- "@mantine/core": "^7.8.1",
- "@mantine/dates": "^7.8.1",
- "@mantine/form": "^7.8.1",
- "@mantine/hooks": "^7.8.1",
- "@mantine/notifications": "^7.8.1",
- "react-plotly.js": "^2.6.0",
- "postcss": "^8.4.38",
- "postcss-preset-mantine": "^1.15.0",
- "postcss-simple-vars": "^7.0.1",
Remove StyleGuideApp unused files

Checklist

Added proper unit tests
Left proper TODO messages for any remaining tasks
Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

amlehman · 2024-05-09T18:17:50Z

A few visual changes I noticed:

Fixed The set modal text field is smaller making the whole modal ... squatter.

Fixed The radio buttons on CDave aren't aligned correctly.

Fixed There's a right margin/padding on the title in both versions of the binning modal on CDave:

Fixed This collapse button on CDave has a border now.

packages/portal-proto/src/features/cDave/ContinuousBinningModal/ContinuousBinningModal.tsx

amlehman · 2024-05-09T17:42:15Z

packages/portal-proto/src/features/cDave/Controls.tsx

-                },
-              },
-              input: {
-                "&:checked + .mantine-Switch-track": {


These hover colors seem a bit darker than the existing ones, especially the orange. Is that an intentional style change?

i was trying to find a suitable color that was already a preset, open to suggestions if this is too dark

It looks good to me 🤷‍♀️ But probably @cemile-ctds 's call.

craigrbarnes · 2024-05-09T20:37:30Z

Fixed Analysis Center: slight sizing issue with the Core Tools cards. The image below overlays this branch ( Mantine 7) on top of develop. It appears the Core Tool cards are 6 pixels shorter.

craigrbarnes · 2024-05-09T20:43:53Z

Mutation Frequency Gene Table (and same with Mutation Table):

Fixed The unselected Survival Plot checkbox fill color should not be blue
Cannot reproduce The link icon to the left of the Gene Symbol is missing

craigrbarnes · 2024-05-09T21:57:52Z

Fixed Project Center more space between buttons and the top of the table. Label "TOTAL OF 83 PROJECTS" not vertically aligned with Search TextInput

craigrbarnes · 2024-05-10T16:04:31Z

Repository:

Fixed There is a slight offset with the table, and the Vertical alignment is slightly shifted down.
Cannot Reproduce The link icons are missing

craigrbarnes · 2024-05-10T16:10:17Z

Slide image viewer:
Fixed There is small gray box that's appearing at the bottom of the slide column

craigrbarnes · 2024-05-10T16:48:20Z

Gene Sumnmary: minor nitpick:

Fixed more/less button in Description row: vertical alignment is shitded down vertically.

wteouchicago · 2024-05-13T16:03:19Z

Some things I noticed.

Fixed The Send Feedback modal has more padding at the top (and also the bottom?) compared to develop. I think it's happening to other modals as well, e.g. Create...Set modal from Manage Sets (see number 2).

Left is develop, right is this PR.

Fixed The underline on the tab in the Create..Set modal is now a box.

Fixed In the Repository, when the spinners on buttons show up, the text is not displayed. Guessing this will happening to all buttons with spinners

click on Add All Files to Cart and Remove All From Cart to get the spinner to show up or click on a dropdown option in Download Associated Data

Fixed cDAVE Search on the left, the X has a box around it. I also can't seem to click on it to get rid of the search text.

wteouchicago · 2024-05-21T17:46:27Z

looks good to me -- I also went over issues others reported. nice work! 👍

craigrbarnes · 2024-05-23T13:24:37Z

packages/portal-proto/src/features/proteinpaint/OncoMatrixWrapper.unit.test.tsx

@@ -45,8 +45,8 @@ test("OncoMatrix arguments", () => {
    <MantineProvider
      theme={{
        colors: {
-          primary: ["1", "2", "3", "4", "5", "6", "7", "8", "9"],
-          base: ["1", "2", "3", "4", "5", "6", "7", "8", "9"],
+          primary: ["1", "2", "3", "4", "5", "6", "7", "8", "9", "10"],


craigrbarnes

I'm okay with the changes to support V7. Great job on implementing such a large-scale change..

ocshawn added 3 commits May 7, 2024 17:10

PEAR-1586

2283b6c

Merge branch 'develop' into chore/updateMantine

42c4be6

Merge branch 'develop' into chore/updateMantine

2d22873

ocshawn marked this pull request as ready for review May 8, 2024 15:32

ocshawn added 3 commits May 8, 2024 14:53

PEAR-1586: fix overrights from merge fix build errors

f01f971

PEAR-1586: adjust tests

44c15ab

PEAR-1586: fix dev build error

462cfaa

amlehman reviewed May 9, 2024

View reviewed changes

PEAR-1586: fix bin validation

f7ec39c

ocshawn added 4 commits May 9, 2024 17:03

PEAR-1586: fix radio grop styling

a0f15de

PEAR-1586: fix set modal text field height

3572d25

PEAR-1586: modal header padding

a356cca

PEAR-1586: cdave left menu icon styling

22c2c26

ocshawn added 3 commits May 10, 2024 15:49

PEAR-1586: CORE TOOLS line hight adjustment

92719a2

PEAR-1586: Fix Mutation Frequency Gene Table Survival Plot checkbox

84e2141

PEAR-1586: Fix viretical table search bar alignment

19b6ed4

ocshawn and others added 6 commits May 13, 2024 11:40

PEAR-1586: Fix slide viewer styling

8bc5f18

PEAR-1586: Fix Collapsible Text Area more button aligment

15d8c97

PEAR-1586: Fix Modal global styles

4d46885

PEAR-1586: Fix matched table tab styles

6532908

PEAR-1586: fix cdave costum bin validation

7741d2d

Merge branch 'develop' into chore/updateMantine

4cee664

Shawn O'Connor added 4 commits May 20, 2024 12:04

PEAR-1586: convert button styling back to v6 styles

8a41d88

PEAR-1586: imput x styling

8db3c53

Merge branch 'develop' into chore/updateMantine

97df7aa

PEAR-1586: fix StyledTabsList missing error

82bc309

craigrbarnes reviewed May 23, 2024

View reviewed changes

craigrbarnes approved these changes May 23, 2024

View reviewed changes

craigrbarnes merged commit 82839e4 into develop May 23, 2024
4 checks passed

craigrbarnes deleted the chore/updateMantine branch May 23, 2024 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(PEAR-1586): Update Mantine to 7 #1113

(PEAR-1586): Update Mantine to 7 #1113

ocshawn commented May 8, 2024 •

edited

amlehman commented May 9, 2024 •

edited by ocshawn

amlehman May 9, 2024

ocshawn May 9, 2024

amlehman May 10, 2024

craigrbarnes commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 10, 2024 •

edited by ocshawn

craigrbarnes commented May 10, 2024 •

edited by ocshawn

craigrbarnes commented May 10, 2024 •

edited by ocshawn

wteouchicago commented May 13, 2024 •

edited by ocshawn

wteouchicago commented May 21, 2024

craigrbarnes May 23, 2024

craigrbarnes left a comment

(PEAR-1586): Update Mantine to 7 #1113

(PEAR-1586): Update Mantine to 7 #1113

Conversation

ocshawn commented May 8, 2024 • edited

Description

Checklist

Screenshots/Screen Recordings (if Appropriate)

amlehman commented May 9, 2024 • edited by ocshawn

amlehman May 9, 2024

Choose a reason for hiding this comment

ocshawn May 9, 2024

Choose a reason for hiding this comment

amlehman May 10, 2024

Choose a reason for hiding this comment

craigrbarnes commented May 9, 2024 • edited by ocshawn

craigrbarnes commented May 9, 2024 • edited by ocshawn

craigrbarnes commented May 9, 2024 • edited by ocshawn

craigrbarnes commented May 10, 2024 • edited by ocshawn

craigrbarnes commented May 10, 2024 • edited by ocshawn

craigrbarnes commented May 10, 2024 • edited by ocshawn

wteouchicago commented May 13, 2024 • edited by ocshawn

wteouchicago commented May 21, 2024

craigrbarnes May 23, 2024

Choose a reason for hiding this comment

craigrbarnes left a comment

Choose a reason for hiding this comment

ocshawn commented May 8, 2024 •

edited

amlehman commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 9, 2024 •

edited by ocshawn

craigrbarnes commented May 10, 2024 •

edited by ocshawn

craigrbarnes commented May 10, 2024 •

edited by ocshawn

craigrbarnes commented May 10, 2024 •

edited by ocshawn

wteouchicago commented May 13, 2024 •

edited by ocshawn