Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit project awards #1652

Open
wants to merge 21 commits into
base: feature-add-project-section-525
Choose a base branch
from

Conversation

wykhuh
Copy link
Collaborator

@wykhuh wykhuh commented Jan 22, 2021

@laurenwalker

  • Allow people to add and edit awards.
  • Allow people to search NSF awards by keyword or award number. Fills out the award form based on selected suggestion.
  • Add validation.
  • Add help text to awards form.

@laurenwalker
Copy link
Member

Thanks Wai-Yin, here are a couple thoughts after an initial review. I'll keep adding to this list as I continue to review, I just wanted to get some items to you to work on ASAP

  • Add numbered headings to each Award ("Award 1", "Award 2", etc.)
  • Remove the old "Funding" field from the Overview section
  • Bug:
    - Click Submit Data to start a new dataset.
    - Enter in basic metadata (title, abstract, dates, and one location) and one award with only a title and a funder name.
    - Click Submit.
    - The dataset gets stuck in the "submitting..." stage forever.
    - When I refresh the page, the console shows the following error:
    Uncaught TypeError: this.get(...) is null at validate EML211.js:1477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants